-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New camera plugin doesn't take pictures on Android when flash is on #72649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @orestesgaolin If you have some additional information in how I can reproduce the issue please write in the comments below. |
@pedromassangocode the code sample was run directly against the code in de P.S. the related PR is flutter/plugins#3314 |
Hi @orestesgaolin |
I updated my app to the newest version of the plugin from commit flutter/plugins@622ba57 but the issue still occurs on Samsung S8. I think this is hardware specific issue i.e. won't occur on other brands or system versions. Are you able to execute the reproduction steps on Samsung S8? I asked my customer to run it on their phones which have similar (but different in practice) issues with camera plugin. I'll let you know more as soon I get this feedback. |
I got the same issue as @orestesgaolin on Samsung S5 and Samsung S6 |
I'm experiencing the same problem, the Device: Google Pixel 3XL |
same issue. |
We have located the cause of this problem and are preparing a fix as we speak. We will make a PR today. |
This should be fixed in flutter/plugins#3367. |
I am runing this plugin on Samsung A31, take picture never completes the process. |
@supratikkoley are you testing with the latest version on the master branch or the version on pub.dev? We created a fix yesterday which has been merged to master but hasn't been released to pub.dev yet. |
I am testing it with puv dev version, |
No problem ;) good news is that a fix is coming soon. |
Hey there, I can confirm that the flash works now with Samsung S8 at flutter/plugins@a9513d5. Please close the issue at your convenience. I encountered a crash while stopping recording, but need to investigate it a bit further and submit separate issue. |
Thanks @orestesgaolin, you are a big help (also al the others that helped testing)! |
@mvanbeusekom When releasing updates, try to check that all modules work properly thirty times. I confirm that version 6.3.1 fixes taking pictures, but video recording has stopped working. E/AndroidRuntime(32209): java.lang.NullPointerException: Attempt to invoke virtual method 'void io.flutter.plugins.camera.PictureCaptureRequest.error(java.lang.String, java.lang.String, java.lang.Object)' on a null object reference |
Turns out this only occurs when a video recording is stopped before any picture has been taken. Although video recording was tested, this specific path was not. It should now be fixed in flutter/plugins#3375. |
@BeMacized how can i test this commit? Unfortunately, it has been blocked for review |
To test this in your own app, you could replace your dependency on the camera plugin with the following:
Otherwise, just pull the branch and run the example app. |
@mvanbeusekom Your last commit "Update camera_platform_interface to 1.2.0 (#3376)" causes the camera to not initialize ;/ Could you check it? The log data only shows the "Connecting to camera service" status. [+1576 ms] D/ViewRootImpl@9af74a5FlutterActivity: ViewPostImeInputStage processPointer 0 |
iam getting same issue pls fix this issue pls test before releasing |
Please fix this ASAP, we can't release a version because of that. |
A PR that fixes this has already been made and accepted a few hours ago (flutter/plugins#3377). We're only waiting for all checks to go green. |
@leszekkrol, @kw2019ltd, if you can't wait for the PR to land and a new version of the plugin to be published, you can workaround the problem using a dependency override adding the following to your pubspec.yaml should solve the issue: dependency_overrides:
camera_platform_interface: ">=1.0.4 <1.1.0" |
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
This bug report is related to new camera 6.X plugin that is aimed to support flash.
Steps to Reproduce
Expected results:
Picture should be taken with flash
Actual results:
Short pre-capture measurement is taken with short flash
cc: @BeMacized @mvanbeusekom @bparrishMines
Logs
The text was updated successfully, but these errors were encountered: