Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[webview_flutter] add consistent API for zoom controls #75196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
NickalasB opened this issue Feb 2, 2021 · 4 comments
Closed

[webview_flutter] add consistent API for zoom controls #75196

NickalasB opened this issue Feb 2, 2021 · 4 comments
Labels
c: proposal A detailed proposal for a change to Flutter p: webview The WebView plugin P3 Issues that are less important to the Flutter project package flutter/packages repository. See also p: labels. platform-ios iOS applications specifically

Comments

@NickalasB
Copy link

This issue is being filed as part of PR feedback for flutter/plugins#3325.

That PR adds the missing ability to enable pinch to zoom and on-screen zoom controls for WebViews running on Android. iOS pinch to zoom already works but there isn't currently a way to disable that functionality if a dev wanted to do so.

The available params that control pinch zoom/on-screen zoom controls on Android's WebView and Apple's WKWebView are not one-to-one but it seems the basic functionality of enabling/disabling zoom on a WebView for both platforms should be possible.
@NickalasB NickalasB mentioned this issue Feb 2, 2021
Merged
13 tasks
@pedromassangocode
Copy link

but there isn't currently a way to disable that functionality if a dev wanted to do so

Is this issue about this statement? Just to make things clear.

@pedromassangocode pedromassangocode added p: first party p: webview The WebView plugin platform-ios iOS applications specifically c: proposal A detailed proposal for a change to Flutter labels Feb 2, 2021
@NickalasB NickalasB changed the title [webview_flutter] add fine-grained zoom controls for iOS [webview_flutter] add consistent API for zoom controls Feb 2, 2021
@NickalasB
Copy link
Author

@pedromassango I update the name of this issue to more accurately reflect the intent, which I believe would be the ability to simply have an enableZoom boolean param on WebView that would allow enabling/disabling of zoom, regardless of platform.

@cyanglaz cyanglaz added the P3 Issues that are less important to the Flutter project label Feb 4, 2021
@stuartmorgan-g
Copy link
Contributor

Fixed by flutter/plugins#3325

@NickalasB NickalasB mentioned this issue Nov 5, 2021
Merged
11 tasks
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2021
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
c: proposal A detailed proposal for a change to Flutter p: webview The WebView plugin P3 Issues that are less important to the Flutter project package flutter/packages repository. See also p: labels. platform-ios iOS applications specifically
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@stuartmorgan-g @cyanglaz @NickalasB @pedromassangocode