@ditman

I assume we don't control the code generator? If we did, a good solution would be to add an ignore for file comment for this hint to the top of the file.

Otherwise, we could add an analysis options file for the google_sign_in_web project that disables the hint (and likely references the default flutter analysis options config).

What's the analysis_options.yaml file that the analyzer is using? The one in plugins excludes lib/src/generated stuff:

https://github.com/flutter/plugins/blob/master/analysis_options.yaml

From the logs:

Running command: "pub global run tuneup check" in /b/s/w/ir/tmp/t/pluginsXTOHXT/packages/google_sign_in/google_sign_in_web

I don't know what tuneup is.

tuneup is a tool that drives the analysis server from the command line. The repo should probably be switched to using dart analyze (or flutter analyze).

As a quick mitigation, I'm going to try and add an // ignore at the file level for the two checks that are failing, see if that cures the build.

What's the analysis_options.yaml file that the analyzer is using? The one in plugins excludes lib/src/generated stuff:

https://github.com/flutter/plugins/blob/master/analysis_options.yaml

Interesting, the repo is using pedantic?

We'll want to either add unused_element as an error to ignore in that file, or target the change to the specific project. That would look something like adding an anaysis_options.yaml file to the https://github.com/flutter/plugins/tree/master/packages/google_sign_in/google_sign_in_web directory:

include: ../../analysis_options.yaml
  errors:
    unused_element: false

Changing the top-level analysis options would be a simpler solution.

adding an anaysis_options.yaml file to the https://github.com/flutter/plugins/tree/master/packages/google_sign_in/google_sign_in_web directory

We've been trying to reduce the amount of custom analysis_options.yaml files in the repo, that's why I pointed to the global one (that excludes generated and mock files).

I've posted a PR with an ignore_for_file for now. I don't know what's the "top-level" analysis options file that is being used in the check that is breaking the rolls :) Modifying that to exclude "generated" code would be nice.

PR here: flutter/plugins#3622

There are new analyzer "info" messages about unused elements, e.g. the class _RequestOptions here:

Are the messages wrong or just undesired here?

Maybe this is the analysis_options.yaml file that is being used?

https://github.com/flutter/flutter/blob/master/analysis_options.yaml#L39-L45

There are new analyzer "info" messages about unused elements, e.g. the class _RequestOptions here:

Are the messages wrong or just undesired here?

I think it's correct that _RequestOptions isn't used in that file. I suspect the @JS annotations might mean that they are needed for JS interop, though?

Yeah, these files were generated from typescript .d.ts files a long time ago. I guess new analyzer rules caught more stuff in these old files. We never saw those in flutter/plugins before because they were ignored, but mostly because it seems they're just rolling now to the flutter tool, so flutter/flutter caught it first, I guess?

I've merged the analyzer tweaks to the generated files, I'm going to check the next plugins -> flutter roll.

The next run of the roller should include the fix above.

Confirmed, the fix is here: #76630

76630 has just landed in master

Next engine roll here: #76636 should work

Is there anything left to track here? Should we close this?

Not that I am aware of. Let's file a new issue if this wasn't completely solved.

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.