Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[web] enable Skia Gold for web integration tests #86120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yjbanov opened this issue Jul 8, 2021 · 2 comments
Closed

[web] enable Skia Gold for web integration tests #86120

yjbanov opened this issue Jul 8, 2021 · 2 comments
Labels
a: tests "flutter test", flutter_test, or one of our tests P2 Important issues not at the top of the work list platform-web Web applications specifically team-web Owned by Web platform team triaged-web Triaged by Web platform team

Comments

@yjbanov
Copy link
Contributor

yjbanov commented Jul 8, 2021

I moved web integration tests from flutter/engine to flutter/flutter but without the ability to take test screenshots (#86119). We should enable these tests to take screenshots and send them to Skia Gold.
@yjbanov yjbanov added a: tests "flutter test", flutter_test, or one of our tests platform-web Web applications specifically P1 High-priority issues at the top of the work list labels Jul 8, 2021
@yjbanov yjbanov self-assigned this Jul 8, 2021
@ferhatb ferhatb mentioned this issue Jul 22, 2021
Closed
@yjbanov yjbanov removed their assignment Oct 21, 2021
@yjbanov yjbanov added P2 Important issues not at the top of the work list and removed P1 High-priority issues at the top of the work list labels Oct 21, 2021
@kenzieschmoll kenzieschmoll mentioned this issue Dec 16, 2022
Merged
@kenzieschmoll kenzieschmoll mentioned this issue Jan 18, 2023
Closed
@flutter-triage-bot flutter-triage-bot bot added team-web Owned by Web platform team triaged-web Triaged by Web platform team labels Jul 8, 2023
@yjbanov
Copy link
Contributor Author

yjbanov commented Mar 26, 2024

We consider engine-side screenshot tests to be sufficient for now.

@yjbanov yjbanov closed this as completed Mar 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests P2 Important issues not at the top of the work list platform-web Web applications specifically team-web Owned by Web platform team triaged-web Triaged by Web platform team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yjbanov @Hixie