-
Notifications
You must be signed in to change notification settings - Fork 28.6k
Add share images support #9817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@chinmaygarde looking for some advice to make sure I'm heading in the right direction. I assume I'd want to expand the sharing Dart API (flutter/plugins#21) to also take in a ui.Image (or some async wrapper of it) in the |
What is the actual use case you're trying to address? ui.Image represents a (possibly deferred) GPU-resident image. If you want to share images from storage (e.g., the user's photo gallery), there might not be a reason to make them GPU-resident. You might want something more like a file descriptor or some other handle to bytes (potentially not memory-resident at all). |
Sorry, didn't mean to get you to answer on Sunday. Thanks, that's the part I wasn't sure. I was trying to see if there were a central point that users already use to show images like ImageProvider that I can reuse to get bytes across in an efficient way to share everything from NetworkImages and stuff from the gallery. It seemed like all the actual bytes were stored in ui.Image in common with ImageProviders. Might be easier in person. I'll come chat with you in the morning. |
Sounds good. |
@lukef mentioned this morning that Posse was likely to use/build share-sheet integration which would want to share images. |
Posse is now tech'd up on Plugins so this is no longer blocking them. They currently believe they can build this themselves. |
Sounds like Posse has a custom implementation that shares image files, though they'll still be interested in sharing image bytes. |
+1 for this request. The plugin should support sharing both local and network images along with text. |
Checking to see if support to share both Text and Images is on the roadmap and possible timeline? We have an app we are developing which needs both. Thanks. |
I am working on this feature and Flutter team has provided feedback during
review. I am learning few stuffs to have it done.
Thanks,
R.Purusothaman
β¦On Tue, Apr 17, 2018 at 12:52 AM, Sun ***@***.***> wrote:
Checking to see if support to share both Text and Images is on the roadmap
and possible timeline? We have an app we are developing which needs both.
Thanks.
β
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9817 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABBx5xUgkLqoEziKNKEvk41X0MChT0oIks5tpO9jgaJpZM4NRUAP>
.
|
ps: @Purus I have noticed that most plugins do not work in iOS with Swift 4 projects enabled. This is the Error:
Thanks. |
any updates on this? @Purus |
will this issue be address soon? @Purus - or is there any other way to share an image file with a flutter app? |
Please, add support for sharing image or files, is hard to call specific api to who haven't experience with IOS for example. Like me lol. |
+1 for the sharing images in Share plugin |
Should this help? https://stackoverflow.com/questions/44181343/how-do-i-share-an-image-on-ios-and-android-using-flutter The answer from Simon has a Swift and Kotlin version. |
We put that functionality into a plugin: https://pub.dartlang.org/packages/esys_flutter_share.
|
@d-wolf Thank you for your help, i will try it soon. |
Any news? |
Any News? |
Waiting to be merged |
|
(I'm going to reopen, because I see that part of the requirement was to share from bytes; flutter/plugins#970 is based on paths.) |
Any plugin in which I can share an app deep link with the offline image preview (base64) ? |
Any updates on the option to share from bytes? |
Hey guys, I see that this was merged: flutter/plugins#970 But I can't seem to find Share.shareFile method using |
@MiguelSOliveira Are you looking for |
Hey @ditman, please correct me if I'm wrong, but I don't think that one will work as I want to share a memory "File" type, and that one takes a path to a file instead. The link I provided works because it takes a "File" type variable, which is exactly what I want. |
@MiguelSOliveira take a look at what was finally merged, I think the code you want is: Share.shareFiles(['${directory.path}/image.jpg']); No need to instantiate the |
you're totally right @ditman, I have to store and write to the file anyways so it's physically in the temporary directory and I can just use that path. Thanks! |
It would be nice to have support for sharing from bytes. |
Closing, as share is now deprecated in favor of share_plus. |
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
#9816 only supports sharing text/links. Embedded image support
The text was updated successfully, but these errors were encountered: