Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Enable track widget creation when generating Generated.xcconfig #101123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 11, 2022
Merged

Enable track widget creation when generating Generated.xcconfig #101123

merged 4 commits into from
Apr 11, 2022

Conversation

yeatse
Copy link
Contributor

@yeatse yeatse commented Mar 31, 2022 •
edited
Loading

When initializing a flutter module project, flutter will generate a Generated.xcconfig for iOS, setting TRACK_WIDGET_CREATION=false. This file is used to generate flutter_export_environment.sh, and finally loaded by podhelper.rb to build into the host app. However when we run flutter attach to it, track-widget-creation defaults to true so hot reload breaks until we hot restart it.

This fix set TRACK_WIDGET_CREATION=true in Generated.xcconfig, making hot reload in add-to-app work as expected.

Fixes #94681

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 31, 2022
@christopherfujino
Copy link
Contributor

@jmagman can you take a look at this one?

jmagman
jmagman reviewed Apr 7, 2022
View reviewed changes
jmagman
jmagman requested changes Apr 8, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to make this the default BuildInfo.debug behavior.

@yeatse
Copy link
Contributor Author

yeatse commented Apr 8, 2022

@jmagman Thanks for your review! Just updated BuildInfo.debug and a few test cases. Please take another look.

jmagman
jmagman reviewed Apr 8, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor null nit.

Thanks for the contribution!

jmagman
jmagman approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jmagman jmagman added waiting for tree to go green platform-ios iOS applications specifically labels Apr 11, 2022
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@jmagman
Copy link
Member

jmagman commented Apr 11, 2022

Adding @christopherfujino for second review, forgot we needed that.

christopherfujino
christopherfujino approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit 3437137 into flutter:master Apr 11, 2022
This was referenced Apr 11, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 11, 2022
@engine-flutter-autoroll
3437137 Enable track widget creation when generating Generated.xcconf…
f36c009 
…ig (flutter/flutter#101123)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2022
@engine-flutter-autoroll
3437137 Enable track widget creation when generating Generated.xcconf…
b6e85b4 
…ig (flutter/flutter#101123)
This was referenced Apr 11, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2022
@engine-flutter-autoroll
3437137 Enable track widget creation when generating Generated.xcconf…
c553622 
…ig (flutter/flutter#101123)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 11, 2022
@engine-flutter-autoroll
3437137 Enable track widget creation when generating Generated.xcconf…
21f2d20 
…ig (flutter/flutter#101123)
@yeatse yeatse deleted the track-widget-creation branch April 12, 2022 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams left review comments

@jmagman jmagman jmagman approved these changes

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOS add-to-app fullscreen example can not hot reload until hot restart
5 participants
@yeatse @christopherfujino @fluttergithubbot @jmagman @jonahwilliams