Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[flutter_tools] Dump backtrace on ios app startup timeout #101610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 12, 2022
Merged

[flutter_tools] Dump backtrace on ios app startup timeout #101610

merged 10 commits into from
Apr 12, 2022

Conversation

christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Apr 8, 2022 •
edited
Loading

Add debugging for #101059 and #95582

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 8, 2022
@christopherfujino christopherfujino marked this pull request as ready for review April 8, 2022 23:10
jmagman
jmagman reviewed Apr 8, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test that pauses and dumps the bt to

flutter/packages/flutter_tools/test/general.shard/ios/ios_deploy_test.dart

Line 94 in 74cdc42

testWithoutContext('debugger attached and stopped', () async {

@christopherfujino
Copy link
Contributor Author

Can you add a test that pauses and dumps the bt to

flutter/packages/flutter_tools/test/general.shard/ios/ios_deploy_test.dart

Line 94 in 74cdc42

testWithoutContext('debugger attached and stopped', () async {

Done, PTAL

jmagman
jmagman approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this, @christopherfujino, LGTM

@fluttergithubbot fluttergithubbot merged commit 2978b59 into flutter:master Apr 12, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2022
@engine-flutter-autoroll
2978b59 [flutter_tools] Dump backtrace on ios app startup timeout (fl…
d07bbfe 
…utter/flutter#101610)
christopherfujino added a commit that referenced this pull request Apr 12, 2022
@christopherfujino
Revert "[flutter_tools] Dump backtrace on ios app startup timeout (#1…
6ce1ec5 
…01610)"

This reverts commit 2978b59.
@christopherfujino christopherfujino mentioned this pull request Apr 12, 2022
Merged
christopherfujino added a commit that referenced this pull request Apr 12, 2022
@christopherfujino
Revert "[flutter_tools] Dump backtrace on ios app startup timeout (#1…
2a65829 
…01610)" (#101761)

This reverts commit 2978b59.
@christopherfujino christopherfujino mentioned this pull request Apr 12, 2022
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 12, 2022
@engine-flutter-autoroll
2978b59 [flutter_tools] Dump backtrace on ios app startup timeout (fl…
64752a6 
…utter/flutter#101610)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmagman jmagman jmagman approved these changes

@zanderso zanderso Awaiting requested review from zanderso

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christopherfujino @jmagman @fluttergithubbot