Add flutter build ipa --no-codesign flag
#101766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf0c7dc to
8b82bbb
Compare
jmagman
commented
Apr 12, 2022
| @@ -141,13 +131,18 @@ class BuildIOSArchiveCommand extends _BuildIOSSubCommand { | |||
|
|
|||
| @override | |||
| Future<FlutterCommandResult> runCommand() async { | |||
| final FlutterCommandResult xcarchiveResult = await super.runCommand(); | |||
| final BuildInfo buildInfo = await getBuildInfo(); | |||
| displayNullSafetyMode(buildInfo); | |||
There was a problem hiding this comment.
This is the 💪 Building with sound null safety 💪 that I moved to before super.runCommand() which actually does the building.
8b82bbb to
3b8c944
Compare
jmagman
commented
Apr 12, 2022
| @@ -141,13 +131,18 @@ class BuildIOSArchiveCommand extends _BuildIOSSubCommand { | |||
|
|
|||
| @override | |||
| Future<FlutterCommandResult> runCommand() async { | |||
| final FlutterCommandResult xcarchiveResult = await super.runCommand(); | |||
| final BuildInfo buildInfo = await getBuildInfo(); | |||
| final BuildInfo buildInfo = await cachedBuildInfo; | |||
There was a problem hiding this comment.
This should have been the late final cachedBuildInfo so getBuildInfo() isn't called twice.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the
--no-codesignflag fromBuildIOSCommandto its base class_BuildIOSSubCommandso it can also be used byBuildIOSArchiveCommand.When flag is set, skip the IPA creation step since that cannot be built without the codesigning settings.
Also, while we're here, rearrange the
Building with sound null safetymessage to happen before the build starts so it isn't just randomly printed at the end. Before that change it looked like:Fixes #101765
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.