Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adds StandardMessageCodec benchmark #101767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gaaclarke
Copy link
Member

This is a benchmark to land before I land my performance fixes.

test exempt: is a test

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 12, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@gaaclarke gaaclarke requested a review from dnfield April 12, 2022 17:34
@Hixie
Copy link
Contributor

Hixie commented Apr 12, 2022

Please don't mark your own PRs as test-exempt, the whole point of the process is that every PR that doesn't have tests needs to be manually checked so as to denormalize the behaviour of writing PRs without tests.

@gaaclarke gaaclarke force-pushed the standardmessagecodec-benchmark branch from 37b3654 to e08c996 Compare April 12, 2022 17:43
@gaaclarke
Copy link
Member Author

Please don't mark your own PRs as test-exempt, the whole point of the process is that every PR that doesn't have tests needs to be manually checked so as to denormalize the behaviour of writing PRs without tests.

@Hixie everything that is landed is reviewed, so it is manually checked. In the case of writing tests it seemed we could trust the author and the reviewer to make that decision and that your attention was only required in more nuanced situations. In any case, I don't think there is harm communicating the explanation. Let me know if you want to format it differently.

@@ -0,0 +1,21 @@
// Copyright 2014 The Flutter Authors. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file intended as part of this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, was on the wrong base. Fixed.

@dnfield
Copy link
Contributor

dnfield commented Apr 12, 2022

I think for this case we should teach the bot about tests under the dev/benchmarks folder....

@gaaclarke gaaclarke force-pushed the standardmessagecodec-benchmark branch from e08c996 to 7d0f0f6 Compare April 12, 2022 19:49
@Hixie
Copy link
Contributor

Hixie commented Apr 12, 2022

test-exempt: is a test

@gaaclarke gaaclarke force-pushed the standardmessagecodec-benchmark branch from bb94311 to 7d0f0f6 Compare April 12, 2022 20:38
@fluttergithubbot fluttergithubbot merged commit e6f3022 into flutter:master Apr 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants