Set the Clipboard more reliably in android semantics integration test. #101851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunhtai
commented
Apr 13, 2022
| @@ -120,29 +120,7 @@ void main() { | |||
| // Ideally this should test the case where there is nothing on the | |||
| // clipboard as well, but there is no reliable way to clear the | |||
| // clipboard on Android devices. | |||
| final SerializableFinder normalTextField = find.descendant( | |||
There was a problem hiding this comment.
I can't really tell why this didn't work some of the time, it looks like running this setup with some state leaked from other test will cause it to fail.
I think it is ok to bypass this setup since this is not the focus of this test
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flake happens when it try to store text into clipboard. This pr simplifies this process.
#98417
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.