Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Exclude armv7 from iOS add-to-app plugins #101943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2022

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Apr 14, 2022

post_install do |installer|
  flutter_post_install(installer)
end

Error looks like:

$ pod install
Add `flutter_post_install(installer)` to your Podfile `post_install` block to build Flutter plugins:

post_install do |installer|
  flutter_post_install(installer)
end

[!] Invalid `Podfile` file: Missing `flutter_post_install(installer)` in Podfile `post_install` block.

 #  from /Users/magder/Projects/samples/add_to_app/plugin/ios_using_plugin/Podfile:12
 #  -------------------------------------------
 #    # Pods for IOSUsingPlugin
 >    install_all_flutter_pods(flutter_application_path)
 #
 #  -------------------------------------------

Fixes #101793
Fixes #75296
Fixes #78368
Unblocks #101793

Samples update: flutter/samples#1079
Website update: flutter/website#7032

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added tool Affects the "flutter" command-line tool. See also t: labels. a: existing-apps Integration with existing apps via the add-to-app flow labels Apr 14, 2022
@jmagman jmagman self-assigned this Apr 14, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 14, 2022
@Hixie
Copy link
Contributor

Hixie commented Apr 14, 2022

test-exempt: is a test

plugin_pods = flutter_parse_dependencies_file_for_ios_plugin(plugins_file)

# flutter_parse_plugins_file is in Flutter root podhelper.rb
plugin_pods = flutter_parse_plugins_file(plugins_file, 'ios')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use

def flutter_parse_plugins_file(file, platform)

installer.pods_project.targets.each do |target|
target.build_configurations.each do |build_configuration|
# flutter_additional_ios_build_settings is in Flutter root podhelper.rb
flutter_additional_ios_build_settings(target)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

def flutter_additional_ios_build_settings(target)

raise 'Missing `flutter_post_install(installer)` in Podfile `post_install` block'
end

require File.expand_path(File.join('packages', 'flutter_tools', 'bin', 'podhelper'), flutter_root)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, would be nice if this were lifted to the top. however, would require a refactor, as the flutter_root function can't be called until it's defined, because in ruby function definitions are expression statements evaluated in order. so not a blocker for this PR.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 5b58d5c into flutter:master Apr 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 15, 2022
@jmagman jmagman deleted the pod-32bit branch April 15, 2022 01:41
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 15, 2022
@jmagman
Copy link
Member Author

jmagman commented Apr 15, 2022

When this hits a tagged beta release, update the website to indicate the version in which the new Ruby method is available flutter/website#7039

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: existing-apps Integration with existing apps via the add-to-app flow c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
4 participants