Exclude armv7 arch from iOS add-to-app integration test hosts #102007
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Added a test. |
| if ((await fileType(builtHostBinary)).contains('armv7')) { | ||
| throw TaskResult.failure('Unexpected armv7 architecture slice in $builtHostBinary'); | ||
| } | ||
| await containsBitcode(builtHostBinary); |
There was a problem hiding this comment.
what does this do?
There was a problem hiding this comment.
You're right, this is a bug. Will fix all the spots in this file.
|
Hmm, the module tests passed in #102012 (flutter/engine#32664) without this change. I'm going to close this and think more about why this wasn't needed. 🤔 |
|
To support removing
armv7iOS arch from the Flutter.framework (flutter/engine#32664), the add-to-app iOS host apps must exclude building that arch.All existing add-to-apps hosts will need to do this migration manually as well. I will update the samples, and the website with instructions:
See also #101943
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.