Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Up CocoaPods minumum to 1.10 #103655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2022
Merged

Up CocoaPods minumum to 1.10 #103655

merged 1 commit into from
May 17, 2022

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented May 12, 2022

I should have done this more than a year ago... See #71531 and flutter/website#5100.

Will also be able to remove note at top of https://docs.flutter.dev/development/platform-integration/ios-app-clip
Screen Shot 2022-05-12 at 1 49 01 PM

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. platform-mac Building on or for macOS specifically labels May 12, 2022
@jmagman jmagman self-assigned this May 12, 2022
cyanglaz
cyanglaz approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
It won't affect the plugin repo, right?

christopherfujino
christopherfujino approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@jmagman
Copy link
Member Author

jmagman commented May 16, 2022

LGTM. It won't affect the plugin repo, right?

Plugins are on CocoaPods 1.11.2 right now, it comes pre-installed on the Cirrus VMs.
https://cirrus-ci.com/task/5222850717024256?logs=upgrade_flutter#L311

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit bf7a326 into flutter:master May 17, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 17, 2022
@engine-flutter-autoroll
bf7a326 Up CocoaPods minumum to 1.10 (flutter/flutter#103655)
730af41
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 17, 2022
@engine-flutter-autoroll
bf7a326 Up CocoaPods minumum to 1.10 (flutter/flutter#103655)
ca961a7
@jmagman jmagman deleted the cocoapods-min branch May 17, 2022 01:32
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
bf7a326 Up CocoaPods minumum to 1.10 (flutter/flutter#103655)
7d25350
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
bf7a326 Up CocoaPods minumum to 1.10 (flutter/flutter#103655)
bdaae9d
@darshankawar darshankawar mentioned this pull request May 8, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyanglaz cyanglaz cyanglaz approved these changes

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees

@jmagman jmagman

Labels
platform-ios iOS applications specifically platform-mac Building on or for macOS specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmagman @fluttergithubbot @cyanglaz @christopherfujino