From 50ffa740d96eca312d1e91497b9122067f9ca49a Mon Sep 17 00:00:00 2001 From: Kenzie Schmoll Date: Wed, 21 Dec 2022 14:08:31 -0800 Subject: [PATCH 1/3] Add integration_test/example tests to the CI --- dev/bots/test.dart | 25 ++++++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/dev/bots/test.dart b/dev/bots/test.dart index 68d1b583c4368..20863b0132f26 100644 --- a/dev/bots/test.dart +++ b/dev/bots/test.dart @@ -1138,7 +1138,7 @@ Future _runWebUnitTests(String webRenderer) async { /// Coarse-grained integration tests running on the Web. Future _runWebLongRunningTests() async { final List tests = [ - for (String buildMode in _kAllBuildModes) + for (String buildMode in _kAllBuildModes) ...[ () => _runFlutterDriverWebTest( testAppDirectory: path.join('packages', 'integration_test', 'example'), target: path.join('test_driver', 'failure.dart'), @@ -1148,6 +1148,27 @@ Future _runWebLongRunningTests() async { // logs. To avoid confusion, silence browser output. silenceBrowserOutput: true, ), + () => _runFlutterDriverWebTest( + testAppDirectory: path.join('packages', 'integration_test', 'example'), + target: path.join('integration_test', 'example_test.dart'), + driver: path.join('test_driver', 'integration_test.dart'), + buildMode: buildMode, + renderer: 'canvaskit', + // This test intentionally fails and prints stack traces in the browser + // logs. To avoid confusion, silence browser output. + silenceBrowserOutput: true, + ), + () => _runFlutterDriverWebTest( + testAppDirectory: path.join('packages', 'integration_test', 'example'), + target: path.join('integration_test', 'extended_test.dart'), + driver: path.join('test_driver', 'extended_integration_test.dart'), + buildMode: buildMode, + renderer: 'canvaskit', + // This test intentionally fails and prints stack traces in the browser + // logs. To avoid confusion, silence browser output. + silenceBrowserOutput: true, + ), + ], // This test specifically tests how images are loaded in HTML mode, so we don't run it in CanvasKit mode. () => _runWebE2eTest('image_loading_integration', buildMode: 'debug', renderer: 'html'), @@ -1281,6 +1302,7 @@ Future _runFlutterDriverWebTest({ required String buildMode, required String renderer, required String testAppDirectory, + String? driver, bool expectFailure = false, bool silenceBrowserOutput = false, }) async { @@ -1295,6 +1317,7 @@ Future _runFlutterDriverWebTest({ [ ...flutterTestArgs, 'drive', + if (driver != null) '--driver=$driver', '--target=$target', '--browser-name=chrome', '--no-sound-null-safety', From e9f92916a7a5aa88f2f74f1d74f38e7e59d9aa7a Mon Sep 17 00:00:00 2001 From: Kenzie Schmoll Date: Wed, 21 Dec 2022 14:25:34 -0800 Subject: [PATCH 2/3] add type --- dev/bots/test.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev/bots/test.dart b/dev/bots/test.dart index 20863b0132f26..b48b4f5245c3e 100644 --- a/dev/bots/test.dart +++ b/dev/bots/test.dart @@ -1138,7 +1138,7 @@ Future _runWebUnitTests(String webRenderer) async { /// Coarse-grained integration tests running on the Web. Future _runWebLongRunningTests() async { final List tests = [ - for (String buildMode in _kAllBuildModes) ...[ + for (String buildMode in _kAllBuildModes) ...[ () => _runFlutterDriverWebTest( testAppDirectory: path.join('packages', 'integration_test', 'example'), target: path.join('test_driver', 'failure.dart'), From 32b6cd33ea6b0ecbb5be663220dcd216bae733cb Mon Sep 17 00:00:00 2001 From: Kenzie Schmoll Date: Wed, 21 Dec 2022 16:28:55 -0800 Subject: [PATCH 3/3] remove silencing --- dev/bots/test.dart | 6 ------ 1 file changed, 6 deletions(-) diff --git a/dev/bots/test.dart b/dev/bots/test.dart index b48b4f5245c3e..e6919b72ab888 100644 --- a/dev/bots/test.dart +++ b/dev/bots/test.dart @@ -1154,9 +1154,6 @@ Future _runWebLongRunningTests() async { driver: path.join('test_driver', 'integration_test.dart'), buildMode: buildMode, renderer: 'canvaskit', - // This test intentionally fails and prints stack traces in the browser - // logs. To avoid confusion, silence browser output. - silenceBrowserOutput: true, ), () => _runFlutterDriverWebTest( testAppDirectory: path.join('packages', 'integration_test', 'example'), @@ -1164,9 +1161,6 @@ Future _runWebLongRunningTests() async { driver: path.join('test_driver', 'extended_integration_test.dart'), buildMode: buildMode, renderer: 'canvaskit', - // This test intentionally fails and prints stack traces in the browser - // logs. To avoid confusion, silence browser output. - silenceBrowserOutput: true, ), ],