From 80d895d469a221c543c86e88b0a6d8ee8565b61e Mon Sep 17 00:00:00 2001 From: a-wallen Date: Wed, 18 Jan 2023 14:27:32 -0800 Subject: [PATCH 1/7] Add new task runner for impeller enabled complex layout test --- ...scroll_perf_impeller_macos__timeline_summary.dart | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 dev/devicelab/bin/tasks/complex_layout_scroll_perf_impeller_macos__timeline_summary.dart diff --git a/dev/devicelab/bin/tasks/complex_layout_scroll_perf_impeller_macos__timeline_summary.dart b/dev/devicelab/bin/tasks/complex_layout_scroll_perf_impeller_macos__timeline_summary.dart new file mode 100644 index 0000000000000..8234d508cf3c2 --- /dev/null +++ b/dev/devicelab/bin/tasks/complex_layout_scroll_perf_impeller_macos__timeline_summary.dart @@ -0,0 +1,12 @@ +// Copyright 2014 The Flutter Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +import 'package:flutter_devicelab/framework/devices.dart'; +import 'package:flutter_devicelab/framework/framework.dart'; +import 'package:flutter_devicelab/tasks/perf_tests.dart'; + +Future main() async { + deviceOperatingSystem = DeviceOperatingSystem.macos; + await task(createComplexLayoutScrollPerfTest(enableImpeller: true)); +} From 032e5724d73fb5645b55e4c4c0dc0ba87dad5187 Mon Sep 17 00:00:00 2001 From: a-wallen Date: Wed, 18 Jan 2023 14:29:26 -0800 Subject: [PATCH 2/7] Add new target in .ci.yaml --- .ci.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/.ci.yaml b/.ci.yaml index 80a9a6b64138d..8c9187551bf26 100644 --- a/.ci.yaml +++ b/.ci.yaml @@ -2609,6 +2609,20 @@ targets: ["devicelab", "hostonly", "mac"] task_name: complex_layout_macos__start_up + - name: Mac complex_layout_scroll_perf_impeller_macos__timeline_summary + recipe: devicelab/devicelab_drone + presubmit: false + timeout: 60 + properties: + dependencies: >- + [ + {"dependency": "xcode", "version": "14a5294e"}, + {"dependency": "gems", "version": "v3.3.14"} + ] + tags: > + ["devicelab", "hostonly", "mac"] + task_name: complex_layout_scroll_perf_impeller_macos__timeline_summary + - name: Mac customer_testing recipe: flutter/flutter timeout: 60 From 6c540d892cbd751d17644f5f3a01529fcd2a1717 Mon Sep 17 00:00:00 2001 From: a-wallen Date: Wed, 18 Jan 2023 14:29:45 -0800 Subject: [PATCH 3/7] Claim ownership of complex_layout_scroll_perf_impeller_macos__timeline_summary --- TESTOWNERS | 1 + 1 file changed, 1 insertion(+) diff --git a/TESTOWNERS b/TESTOWNERS index 4acd16a7b16c5..8bff81b17ae5c 100644 --- a/TESTOWNERS +++ b/TESTOWNERS @@ -214,6 +214,7 @@ /dev/devicelab/bin/tasks/channels_integration_test_macos.dart @gaaclarke @flutter/desktop /dev/devicelab/bin/tasks/complex_layout_macos__compile.dart @a-wallen @flutter/desktop /dev/devicelab/bin/tasks/complex_layout_macos__start_up.dart @a-wallen @flutter/desktop +/dev/devicelab/bin/tasks/complex_layout_scroll_perf_impeller_macos__timeline_summary.dart @a-wallen @flutter/desktop /dev/devicelab/bin/tasks/complex_layout_win_desktop__compile.dart @yaakovschectman @flutter/desktop /dev/devicelab/bin/tasks/complex_layout_win_desktop__start_up.dart @yaakovschectman @flutter/desktop /dev/devicelab/bin/tasks/dart_plugin_registry_test.dart @stuartmorgan @flutter/plugin From 060cb68cf0ea20d1ed337e2ed50b427df59dafd9 Mon Sep 17 00:00:00 2001 From: a-wallen Date: Wed, 18 Jan 2023 14:30:50 -0800 Subject: [PATCH 4/7] Task runner for non-impeller enabled scroll test --- ...x_layout_scroll_perf_macos__timeline_summary.dart | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 dev/devicelab/bin/tasks/complex_layout_scroll_perf_macos__timeline_summary.dart diff --git a/dev/devicelab/bin/tasks/complex_layout_scroll_perf_macos__timeline_summary.dart b/dev/devicelab/bin/tasks/complex_layout_scroll_perf_macos__timeline_summary.dart new file mode 100644 index 0000000000000..9f3599b65c7a4 --- /dev/null +++ b/dev/devicelab/bin/tasks/complex_layout_scroll_perf_macos__timeline_summary.dart @@ -0,0 +1,12 @@ +// Copyright 2014 The Flutter Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +import 'package:flutter_devicelab/framework/devices.dart'; +import 'package:flutter_devicelab/framework/framework.dart'; +import 'package:flutter_devicelab/tasks/perf_tests.dart'; + +Future main() async { + deviceOperatingSystem = DeviceOperatingSystem.macos; + await task(createComplexLayoutScrollPerfTest()); +} From febd73cc18f4e3231a5cd05f671c02e47f94dc28 Mon Sep 17 00:00:00 2001 From: a-wallen Date: Wed, 18 Jan 2023 14:31:58 -0800 Subject: [PATCH 5/7] Add test target for non impeller complex layout scroll --- .ci.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/.ci.yaml b/.ci.yaml index 8c9187551bf26..8e2e49482f6c4 100644 --- a/.ci.yaml +++ b/.ci.yaml @@ -2623,6 +2623,20 @@ targets: ["devicelab", "hostonly", "mac"] task_name: complex_layout_scroll_perf_impeller_macos__timeline_summary + - name: Mac complex_layout_scroll_perf_macos__timeline_summary + recipe: devicelab/devicelab_drone + presubmit: false + timeout: 60 + properties: + dependencies: >- + [ + {"dependency": "xcode", "version": "14a5294e"}, + {"dependency": "gems", "version": "v3.3.14"} + ] + tags: > + ["devicelab", "hostonly", "mac"] + task_name: complex_layout_scroll_perf_macos__timeline_summary + - name: Mac customer_testing recipe: flutter/flutter timeout: 60 From 756f596f08528294a7f2e1fb0a6468f08efdf3dd Mon Sep 17 00:00:00 2001 From: a-wallen Date: Wed, 18 Jan 2023 14:32:34 -0800 Subject: [PATCH 6/7] claim ownership of the last target --- TESTOWNERS | 1 + 1 file changed, 1 insertion(+) diff --git a/TESTOWNERS b/TESTOWNERS index 8bff81b17ae5c..37a6425f1bc4f 100644 --- a/TESTOWNERS +++ b/TESTOWNERS @@ -215,6 +215,7 @@ /dev/devicelab/bin/tasks/complex_layout_macos__compile.dart @a-wallen @flutter/desktop /dev/devicelab/bin/tasks/complex_layout_macos__start_up.dart @a-wallen @flutter/desktop /dev/devicelab/bin/tasks/complex_layout_scroll_perf_impeller_macos__timeline_summary.dart @a-wallen @flutter/desktop +/dev/devicelab/bin/tasks/complex_layout_scroll_perf_macos__timeline_summary.dart @a-wallen @flutter/desktop /dev/devicelab/bin/tasks/complex_layout_win_desktop__compile.dart @yaakovschectman @flutter/desktop /dev/devicelab/bin/tasks/complex_layout_win_desktop__start_up.dart @yaakovschectman @flutter/desktop /dev/devicelab/bin/tasks/dart_plugin_registry_test.dart @stuartmorgan @flutter/plugin From a52874c29c9826c8ea9c1cf2d9e45b59e224f03f Mon Sep 17 00:00:00 2001 From: a-wallen Date: Wed, 18 Jan 2023 14:36:20 -0800 Subject: [PATCH 7/7] mark as bringup --- .ci.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.ci.yaml b/.ci.yaml index 8e2e49482f6c4..987f5d77bd61b 100644 --- a/.ci.yaml +++ b/.ci.yaml @@ -2610,6 +2610,7 @@ targets: task_name: complex_layout_macos__start_up - name: Mac complex_layout_scroll_perf_impeller_macos__timeline_summary + bringup: true recipe: devicelab/devicelab_drone presubmit: false timeout: 60 @@ -2624,6 +2625,7 @@ targets: task_name: complex_layout_scroll_perf_impeller_macos__timeline_summary - name: Mac complex_layout_scroll_perf_macos__timeline_summary + bringup: true recipe: devicelab/devicelab_drone presubmit: false timeout: 60