Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Handle dragging a bottom sheet past the bottom #5541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2016
Merged

Handle dragging a bottom sheet past the bottom #5541

merged 1 commit into from
Aug 23, 2016

Conversation

HansMuller
Copy link
Contributor

@HansMuller HansMuller commented Aug 23, 2016 •
edited
Loading

There were two problems here:

  • BottomSheet was responding to a drag-end event by flinging its controller towards 0.0. Even if the controller's value was already 0.0.
  • The Scaffold assumed that the bottom sheet would always call its onDismissed callback before its onClosing callback. If the user drags the bottom sheet off the bottom of the screen, onDismissed is called first because the controller's value reaches zero when the bottom sheet disappears.

Fixes #5528
Fixes #3232

@HansMuller
Copy link
Contributor Author

cc @Hixie

@Hixie
Copy link
Contributor

Hixie commented Aug 23, 2016

LGTM

@HansMuller HansMuller merged commit 310a981 into flutter:master Aug 23, 2016
@HansMuller HansMuller deleted the bottom_sheet_fix branch August 23, 2016 22:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@HansMuller @Hixie