Detect ARM ffi CocoaPods error, suggest gem install #70801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
commented
Nov 19, 2020
| ); | ||
| pretendPodVersionIs('1.8.0'); | ||
| pretendPodVersionIs('1.9.0'); |
There was a problem hiding this comment.
This should have been updated with #69809 and was mucking up the error text.
| ..createSync() | ||
| ..writeAsStringSync('Existing Podfile'); | ||
|
|
||
| when(mockProcessManager.runSync(<String>['sysctl', 'hw.optional.arm64'])) |
There was a problem hiding this comment.
Adding this file to my mental list to swap to FakeProcessManager. Make the new tests match the rest of the file, for now.
This was referenced Nov 23, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CocoaPods crashes on ARM Macs if the x86 version of the
ffigem isn't installed.Detect this crash and tell users how to fix it.
Related Issues
#70796
Tests
cocoapods_tests