Support trackpad gestures in framework #89944

moffatman · 2021-09-12T15:53:27Z

This commit adds support for new pointer events to convey trackpad gesture information. These new events will trigger existing widgets that expect scale or pan gestures.

Three new types of events (PointerPanZoomStartEvent, PointerPanZoomUpdateEvent, PointerPanZoomEndEvent) to convey the states of a trackpad gesture
GestureRecognizers can handle pointer flows (the relevant ones DragGestureRecognizer and ScaleGestureRecognizer have been updated)
GestureDetector has been updated so that onScale, onPan, onVerticalDrag, and onHorizontalDrag will trigger from trackpad gestures

Design Document

Engine PR: flutter/engine#28571

Addresses #23604
Closes #63084

Widgets that use GestureRecognizers directly instead of GestureDetector will need to handle the onPointerPanZoomStart callback of Listener with their GestureRecognizers to receive trackpad gesture events.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
All existing and new tests are passing.

christopherfujino · 2022-02-03T22:14:00Z

I'm removing the tool label, as the only tool change is a single key in an XML config template.

dkwingsmt

Sorry for taking so long. Only minor changes requested.

Thanks for preparing this huge PR!

packages/flutter/lib/src/gestures/monodrag.dart

packages/flutter/lib/src/gestures/recognizer.dart

packages/flutter/lib/src/widgets/gesture_detector.dart

dkwingsmt · 2022-03-08T13:21:53Z

packages/flutter/lib/src/widgets/basic.dart

@@ -6108,6 +6111,15 @@ class Listener extends SingleChildRenderObjectWidget {
  /// no longer directed towards this receiver.
  final PointerCancelEventListener? onPointerCancel;

+  /// Called when a pan/zoom begins such as from a trackpad gesture


I don't feel like using "/" in official names. I'm thinking if we can use pan-zoom. But let's see what others think before making the change.

Also, I mentioned this elsewhere, but this also includes rotation, right?

Otherwise to me, pan/zoom seems like pan or zoom, and pan-zoom seems like pan and zoom. In my testing on my Macbook, it seems like a 2 finder pan gesture is treated separately from a pinch-to-zoom, so maybe pan/zoom is most accurate? See my discussion about combining gestures like this in my main review comment.

Also, add periods at the end of these 3 comments.

packages/flutter/lib/src/gestures/scale.dart

alexeylopukh · 2022-05-03T16:15:15Z

The list scroll should stop on a tap. Now this is especially inconvenient, if you push the list a little, it will scroll for several seconds and at this time you can’t click anything in the list + you can’t stop it.

jmagman · 2022-05-03T17:12:34Z

@alexeylopukh can you file a new issue describing what you're seeing and what should happen instead?

theniceboy · 2022-07-29T21:12:23Z

This PR introduces a breaking change @dkwingsmt

Listener(
  onPointerSignal: (sig) {
    if (sig is PointerScrollEvent) { /* this is no longer triggered on trackpad scroll*/ }
  },
)

…163898) [ScrollBehavior.dragDevices](https://api.flutter.dev/flutter/widgets/ScrollBehavior/dragDevices.html) docs say > By default only PointerDeviceKind.touch, PointerDeviceKind.stylus, and PointerDeviceKind.invertedStylus are configured to create drag gestures. However, `PointerDeviceKind.trackpad` is also included by default #89944 https://github.com/flutter/flutter/blob/401ab831ee56bb31b8beceb0a08bc3293f1a9788/packages/flutter/lib/src/widgets/scroll_configuration.dart#L115-L119 https://github.com/flutter/flutter/blob/401ab831ee56bb31b8beceb0a08bc3293f1a9788/packages/flutter/lib/src/widgets/scroll_configuration.dart#L33 Update the comment to include `trackpad`: > By default only PointerDeviceKind.touch, PointerDeviceKind.stylus, PointerDeviceKind.invertedStylus, **and PointerDeviceKind.trackpad** are configured to create drag gestures. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Sep 12, 2021

google-cla bot added the cla: yes label Sep 12, 2021

goderbauer requested a review from dkwingsmt September 15, 2021 21:52

moffatman force-pushed the trackpad_gestures branch from 79d08f3 to 2449c4b Compare September 19, 2021 17:12

moffatman force-pushed the trackpad_gestures branch from 2449c4b to 9387f14 Compare September 27, 2021 22:12

moffatman force-pushed the trackpad_gestures branch from 9387f14 to 93ca3d0 Compare October 20, 2021 19:45

flutter-dashboard bot added the f: gestures flutter/packages/flutter/gestures repository. label Oct 21, 2021

moffatman mentioned this pull request Oct 21, 2021

Add trackpad gesture PointerData types flutter/engine#28571

Merged

8 tasks

moffatman force-pushed the trackpad_gestures branch 2 times, most recently from 1dd37a9 to 7489668 Compare November 9, 2021 05:33

moffatman force-pushed the trackpad_gestures branch from 7489668 to 0f679c4 Compare November 30, 2021 03:33

moffatman force-pushed the trackpad_gestures branch from 0f679c4 to 3db475f Compare December 9, 2021 00:45

moffatman force-pushed the trackpad_gestures branch from 3db475f to ea2ddf7 Compare December 30, 2021 15:29

moffatman force-pushed the trackpad_gestures branch 2 times, most recently from be93d39 to a9268a7 Compare January 14, 2022 22:47

moffatman marked this pull request as ready for review January 21, 2022 15:18

christopherfujino removed the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 3, 2022

moffatman force-pushed the trackpad_gestures branch 2 times, most recently from 27bf470 to c845637 Compare February 10, 2022 15:14

moffatman mentioned this pull request Feb 11, 2022

Reland: Trackpad gesture PointerData types flutter/engine#31402

Merged

8 tasks

moffatman force-pushed the trackpad_gestures branch 4 times, most recently from f70655e to 20a63c0 Compare February 18, 2022 02:50

moffatman force-pushed the trackpad_gestures branch from 2bed953 to f1c56e2 Compare February 25, 2022 21:25

dkwingsmt requested changes Mar 10, 2022

View reviewed changes

moffatman force-pushed the trackpad_gestures branch from f1c56e2 to 5701063 Compare March 11, 2022 23:13

moffatman added 9 commits April 12, 2022 15:48

Touch and Pan/Zoom pointers have separate IDs now

2de1dd6

Handle trackpad pointer device type

202d864

Respect supportedDevices for pan/zoom events

d6c3807

Update after rebase

d6f9c38

Fix check failures

f5579be

Avoid error with very short drags

2ca3981

Address feedback

3ae4e7f

Refactor drag event handler

80536f1

Address more feedback

de6479e

moffatman force-pushed the trackpad_gestures branch 2 times, most recently from a4302fe to 248c3ae Compare April 12, 2022 19:52

Add some missing punctuation

a379831

moffatman force-pushed the trackpad_gestures branch from 248c3ae to a379831 Compare April 12, 2022 20:17

dkwingsmt merged commit 30a5018 into flutter:master Apr 13, 2022

engine-flutter-autoroll mentioned this pull request Apr 13, 2022

Roll Flutter from 38f360f91a95 to 30a501801af7 (1 revision) flutter/packages#1507

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 13, 2022

30a5018 Support trackpad gestures in framework (flutter/flutter#89944)

c0d2889

engine-flutter-autoroll mentioned this pull request Apr 13, 2022

Roll Flutter from 888208c1f4e0 to fd73f2730c78 (10 revisions) flutter/plugins#5246

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 13, 2022

30a5018 Support trackpad gestures in framework (flutter/flutter#89944)

6cab9a2

Piinks mentioned this pull request Jun 13, 2022

InteractiveViewer should support mouse scrolling #64210

Closed

moffatman mentioned this pull request Jun 30, 2022

Add UIApplicationSupportsIndirectInputEvents migration #106889

Merged

8 tasks

ltOgt mentioned this pull request Jul 2, 2022

GestureDetector onPan now triggers via trackpad. changed application behaviour #107005

Closed

dkwingsmt mentioned this pull request Jul 18, 2022

PointerEvent asserts device kinds #105987

Merged

8 tasks

moffatman mentioned this pull request Sep 9, 2022

Drag trackpad gestures fluttercandies/extended_image#515

Closed

jpnurmi mentioned this pull request Oct 14, 2022

Example: fix touchpad/gesture scrolling on Wayland ubuntu/yaru.dart#302

Merged

jmagman mentioned this pull request Feb 21, 2025

Update dragDevices doc to include default PointerDeviceKind.trackpad #163898

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support trackpad gestures in framework #89944

Support trackpad gestures in framework #89944

Uh oh!

moffatman commented Sep 12, 2021 •

edited by justinmc

Loading

Uh oh!

christopherfujino commented Feb 3, 2022

Uh oh!

dkwingsmt left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dkwingsmt Mar 8, 2022

Uh oh!

justinmc Mar 30, 2022

Uh oh!

justinmc Mar 30, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexeylopukh commented May 3, 2022

Uh oh!

jmagman commented May 3, 2022

Uh oh!

theniceboy commented Jul 29, 2022

Uh oh!

Uh oh!

Support trackpad gestures in framework #89944

Support trackpad gestures in framework #89944

Uh oh!

Conversation

moffatman commented Sep 12, 2021 • edited by justinmc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

christopherfujino commented Feb 3, 2022

Uh oh!

dkwingsmt left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dkwingsmt Mar 8, 2022

Choose a reason for hiding this comment

Uh oh!

justinmc Mar 30, 2022

Choose a reason for hiding this comment

Uh oh!

justinmc Mar 30, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexeylopukh commented May 3, 2022

Uh oh!

jmagman commented May 3, 2022

Uh oh!

theniceboy commented Jul 29, 2022

Uh oh!

Uh oh!

moffatman commented Sep 12, 2021 •

edited by justinmc

Loading

dkwingsmt left a comment •

edited

Loading