Report progress on Dismissible update callback #95504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piinks
reviewed
Jan 7, 2022
| @@ -12,6 +12,7 @@ const DismissDirection defaultDismissDirection = DismissDirection.horizontal; | |||
| const double crossAxisEndOffset = 0.5; | |||
| bool reportedDismissUpdateReached = false; | |||
| bool reportedDismissUpdatePreviousReached = false; | |||
| double reportedDismissUpdateProgress = 0.0; | |||
There was a problem hiding this comment.
Can you add tests for non-zero cases?
There was a problem hiding this comment.
I went back to check and it turns out I forgot to update the value using the callback.
It's fixed now, I'll commit shortly.
There was a problem hiding this comment.
Can you add another test that validates it reports the right value somewhere in between 0 and 1? Thanks!
Piinks
reviewed
Jan 10, 2022
| @@ -12,6 +12,7 @@ const DismissDirection defaultDismissDirection = DismissDirection.horizontal; | |||
| const double crossAxisEndOffset = 0.5; | |||
| bool reportedDismissUpdateReached = false; | |||
| bool reportedDismissUpdatePreviousReached = false; | |||
| double reportedDismissUpdateProgress = 0.0; | |||
There was a problem hiding this comment.
Can you add another test that validates it reports the right value somewhere in between 0 and 1? Thanks!
Piinks
approved these changes
Jan 21, 2022
|
Thanks. I'm sorry it took so long, I didn't notice that the tests were failing since last week. |
|
I'm kind of new to this, is there anything else required from my side? |
|
Nope sorry, we just didn't notice it was ready to land! My bad! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 5, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 5, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 8, 2022
This was referenced Feb 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 9, 2022
NATHANIELCROSBY1
added a commit
to NATHANIELCROSBY1/flutter
that referenced
this pull request
Feb 19, 2022
@NATHANIELCROSBY1 NATHANIELCROSBY1 create … 609e127 13 days ago Git stats 27,477 commits Files Type Name Latest commit message Commit time .github Bump github/codeql-action from 1.0.26 to 1.0.31 (flutter#97820) 14 days ago bin Roll Engine from 2a4709a to 0712096 (1 revision) (flutter#9… 13 days ago dev Include -isysroot -arch and -miphoneos-version-min when creating dumm… 15 days ago examples Clean up the bindings APIs. (flutter#89451) 16 days ago packages Report progress on Dismissible update callback (flutter#95504) 14 days ago .ci.yaml Marks Linux_android opacity_peephole_fade_transition_text_perf__e2e_s… 15 days ago .cirrus.yml Pin dependencies in docker file. (flutter#97466) 18 days ago .gitattributes Add pre-stable support for create on Windows (flutter#51895) 2 years ago .gitignore Add macOS ephemeral to gitignore (flutter#96397) 20 days ago AUTHORS Mirror before scaling in _AnimatedIconPainter (flutter#93312) 24 days ago CODEOWNERS [codeowners] Remove *_builders.json ownership (flutter#91691) 4 months ago CODE_OF_CONDUCT.md Update CODE_OF_CONDUCT.md (flutter#94583) 3 months ago CONTRIBUTING.md Links How to contribute to Flutter YouTube video (flutter#96313) last month LICENSE License update (flutter#45373) 2 years ago PATENT_GRANT Rename patent file (flutter#38686) 3 years ago README.md Update README (flutter#97271) 24 days ago TESTOWNERS Add benchmarks to measure impact of alpha saveLayers in DisplayLists (f… 23 days ago analysis_options.yaml Enable no_leading_underscores_for_local_identifiers (flutter#96422) 29 days ago dartdoc_options.yaml Eliminate uses of pub executable in docs publishing and sample analys… 6 months ago flutter_console.bat License update (flutter#45373) 2 years ago git clone create 13 days ago README.md Flutter logo Build Status - Cirrus Discord badge Twitter handle Flutter is Google's SDK for crafting beautiful, fast user experiences for mobile, web, and desktop from a single codebase. Flutter works with existing code, is used by developers and organizations around the world, and is free and open source. Documentation Install Flutter Flutter documentation Development wiki Contributing to Flutter For announcements about new releases, follow the [email protected] mailing list. Our documentation also tracks breaking changes across releases. Terms of service The Flutter tool may occasionally download resources from Google servers. By downloading or using the Flutter SDK you agree to the Google Terms of Service: https://policies.google.com/terms For example, when installed from GitHub (as opposed to from a prepackaged archive), the Flutter tool will download the Dart SDK from Google servers immediately when first run, as it is used to execute the flutter tool itself. This will also occur when Flutter is upgraded (e.g. by running the flutter upgrade command). About Flutter We think Flutter will help you create beautiful, fast apps, with a productive, extensible and open development model, whether you're targeting iOS or Android, web, Windows, macOS, Linux or embedding it as the UI toolkit for a platform of your choice. Beautiful user experiences We want to enable designers to deliver their full creative vision without being forced to water it down due to limitations of the underlying framework. Flutter's layered architecture gives you control over every pixel on the screen and its powerful compositing capabilities let you overlay and animate graphics, video, text, and controls without limitation. Flutter includes a full set of widgets that deliver pixel-perfect experiences whether you're building for iOS (Cupertino) or Android (Material), along with support for customizing or creating entirely new visual components. Reflectly hero image Fast results Flutter is fast. It's powered by the same hardware-accelerated 2D graphics library that underpins Chrome and Android: Skia. We architected Flutter to support glitch-free, jank-free graphics at the native speed of your device. Flutter code is powered by the world-class Dart platform, which enables compilation to 32-bit and 64-bit ARM machine code for iOS and Android, as well as JavaScript for the web and Intel x64 for desktop devices. Dart diagram Productive development Flutter offers stateful hot reload, allowing you to make changes to your code and see the results instantly without restarting your app or losing its state. Hot reload animation Extensible and open model Flutter works with any development tool (or none at all), and also includes editor plug-ins for both Visual Studio Code and IntelliJ / Android Studio. Flutter provides tens of thousands of packages to speed your development, regardless of your target platform. And accessing other native code is easy, with support for both FFI and platform-specific APIs. Flutter is a fully open-source project, and we welcome contributions. Information on how to get started can be found in our contributor guide.
8 tasks
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
progressparameter to the DismissibleonUpdatecallback.The value represents how far the dismissible child has been dragged in its parent container as a ratio value between 0.0 and 1.0, which can be useful to e.g. fade elements in sync with the gesture.
This implementation also correctly reports the position during the return animation when the dismiss is unsuccessful.
This PR partly solves #21230 (3rd. point) and closes #74582
Pre-launch Checklist
///).