Disallow flutter run-ing on 32-bit development devices
#97339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm I guess this needs to wait a few months...?
|
|
I will mark this as draft then |
948e3ce to
9b6444d
Compare
9b6444d to
7cce7eb
Compare
|
This is ready for review! |
| @@ -302,7 +302,8 @@ class IOSDevice extends Device { | |||
| } | |||
|
|
|||
| @override | |||
| bool isSupported() => true; | |||
| // 32-bit devices are not supported. | |||
| bool isSupported() => cpuArchitecture == DarwinArch.arm64; | |||
There was a problem hiding this comment.
Does this never get called with cpuArchitecture == x64 on simulators?
There was a problem hiding this comment.
No, this is in IOSDevice which is for physical devices. Simulators are handled here:
|
Waiting for @zanderso to say go post branch alignment. |
|
Being a little over cautious: As soon as the current g3 roll lands and sticks we can start on this. |
zanderso
approved these changes
Apr 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
32-bit iOS tests have been removed from the devicelab: #97148.
Fixes #97329.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.