Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use ValueKey finder instead of text finder in keyboard_textfield_test #97996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2022
Merged

Use ValueKey finder instead of text finder in keyboard_textfield_test #97996

merged 1 commit into from
Feb 8, 2022

Conversation

LongCatIsLooong
Copy link
Contributor

My last ditch effort for figuring what went wrong in #96787

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. labels Feb 8, 2022
jmagman
jmagman approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

If this doesn't work, maybe on failure have it print the hierarchy to see what it does find?

@LongCatIsLooong
Copy link
Contributor Author

RSLGTM

If this doesn't work, maybe on failure have it print the hierarchy to see what it does find?

Is there a way to do so when the test times out?

@jmagman
Copy link
Member

jmagman commented Feb 8, 2022

Is there a way to do so when the test times out?

Maybe instead of waitFor it, pump, check, pump, check, etc, and when 5 seconds is up without it existing, print something like debugDumpApp? There may be a better way, I haven't written many drive tests.

@fluttergithubbot fluttergithubbot merged commit 213f766 into flutter:master Feb 8, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
213f766 Use ValueKey finder instead of text finder in keyboard_textfi…
0dd82e2 
…eld_test (flutter/flutter#97996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
213f766 Use ValueKey finder instead of text finder in keyboard_textfi…
2cd6759 
…eld_test (flutter/flutter#97996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
213f766 Use ValueKey finder instead of text finder in keyboard_textfi…
ad35227 
…eld_test (flutter/flutter#97996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
213f766 Use ValueKey finder instead of text finder in keyboard_textfi…
aa934cb 
…eld_test (flutter/flutter#97996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
213f766 Use ValueKey finder instead of text finder in keyboard_textfi…
fa3b71e 
…eld_test (flutter/flutter#97996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
213f766 Use ValueKey finder instead of text finder in keyboard_textfi…
757de82 
…eld_test (flutter/flutter#97996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
213f766 Use ValueKey finder instead of text finder in keyboard_textfi…
c80197f 
…eld_test (flutter/flutter#97996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
213f766 Use ValueKey finder instead of text finder in keyboard_textfi…
4b8e6fe 
…eld_test (flutter/flutter#97996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
213f766 Use ValueKey finder instead of text finder in keyboard_textfi…
f7678ed 
…eld_test (flutter/flutter#97996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
213f766 Use ValueKey finder instead of text finder in keyboard_textfi…
971bb19 
…eld_test (flutter/flutter#97996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
213f766 Use ValueKey finder instead of text finder in keyboard_textfi…
350b385 
…eld_test (flutter/flutter#97996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
213f766 Use ValueKey finder instead of text finder in keyboard_textfi…
c495116 
…eld_test (flutter/flutter#97996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
213f766 Use ValueKey finder instead of text finder in keyboard_textfi…
dbb073b 
…eld_test (flutter/flutter#97996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
213f766 Use ValueKey finder instead of text finder in keyboard_textfi…
b1e81f0 
…eld_test (flutter/flutter#97996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
213f766 Use ValueKey finder instead of text finder in keyboard_textfi…
b6dff75 
…eld_test (flutter/flutter#97996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
213f766 Use ValueKey finder instead of text finder in keyboard_textfi…
2cda1ba 
…eld_test (flutter/flutter#97996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
213f766 Use ValueKey finder instead of text finder in keyboard_textfi…
ca5be61 
…eld_test (flutter/flutter#97996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
213f766 Use ValueKey finder instead of text finder in keyboard_textfi…
577fa99 
…eld_test (flutter/flutter#97996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
213f766 Use ValueKey finder instead of text finder in keyboard_textfi…
14494f4 
…eld_test (flutter/flutter#97996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
213f766 Use ValueKey finder instead of text finder in keyboard_textfi…
3baf6ff 
…eld_test (flutter/flutter#97996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
213f766 Use ValueKey finder instead of text finder in keyboard_textfi…
c950592 
…eld_test (flutter/flutter#97996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
213f766 Use ValueKey finder instead of text finder in keyboard_textfi…
bddeac8 
…eld_test (flutter/flutter#97996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
213f766 Use ValueKey finder instead of text finder in keyboard_textfi…
76ab890 
…eld_test (flutter/flutter#97996)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
213f766 Use ValueKey finder instead of text finder in keyboard_textfi…
6ce0ddb 
…eld_test (flutter/flutter#97996)
@LongCatIsLooong LongCatIsLooong deleted the keyboard-test-flakiness-take1 branch February 11, 2022 23:34
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@LongCatIsLooong @clocksmith
Use ValueKey finder instead of text finder in keyboard_textfield_test (…
fc9cbcc 
…flutter#97996)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmagman jmagman jmagman approved these changes

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LongCatIsLooong @jmagman @fluttergithubbot