Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "Update plugin lint test for federated url_launcher plugin" #98166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Feb 10, 2022

Reverts #94374

#98165

url_launcher became unfederated somehow. Temporarily reverting this to re-open the tree.
#98165

Test that needs to pass: https://ci.chromium.org/p/flutter/builders/try/Mac%20plugin_lint_mac/11005

@jmagman jmagman self-assigned this Feb 10, 2022
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 10, 2022
@jmagman
Copy link
Member Author

jmagman commented Feb 10, 2022

Test that needs to pass: https://ci.chromium.org/p/flutter/builders/try/Mac%20plugin_lint_mac/11005

This test hit infra issue #97303

@jmagman
Copy link
Member Author

jmagman commented Feb 10, 2022

#98171 is a better fix, keeping this open for now but will close when infra issues unwedge and that one can merge.

@jmagman
Copy link
Member Author

jmagman commented Feb 10, 2022

#98171 is still failing, let's merge this one to reopen the tree, and I'll keep investigating.

@jmagman jmagman requested a review from HansMuller February 10, 2022 22:57
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@jmagman
Copy link
Member Author

jmagman commented Feb 10, 2022

Merging on red.

@jmagman jmagman merged commit ea6025c into master Feb 10, 2022
@jmagman jmagman deleted the revert-94374-url-launcher branch February 10, 2022 22:59
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 10, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
jmagman added a commit to jmagman/flutter that referenced this pull request Feb 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants