Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Override OS and Xcode version for plugin_lint_mac #98210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2022
Merged

Override OS and Xcode version for plugin_lint_mac #98210

merged 1 commit into from
Feb 10, 2022

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Feb 10, 2022

Work around #97303 by trying the newer version of Xcode and macOS.

@jmagman jmagman added the team-infra Owned by Infrastructure team label Feb 10, 2022
@jmagman jmagman self-assigned this Feb 10, 2022
CaseyHillers
CaseyHillers reviewed Feb 10, 2022
View reviewed changes
.ci.yaml
@@ -2752,6 +2752,8 @@ targets:
tags: >
["devicelab","hostonly"]
task_name: plugin_lint_mac
os: Mac-12 # Override OS and Xcode for https://github.com/flutter/flutter/issues/97303
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the todo that this would eventually become the default for all the Mac tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that works is being done in #98144.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, that work is being done with #98144.

@jmagman
Copy link
Member Author

jmagman commented Feb 10, 2022

Same issue seen in #98144 it's not using the os override and it's installing the new version of Xcode on an old version of macOS, which fails. https://ci.chromium.org/p/flutter/builders/try/Mac%20plugin_lint_mac/11020?

@keyonghan
Copy link
Contributor

flutter/cocoon#1597 to pass dimensions in pre-submit tests.

@jmagman
Copy link
Member Author

jmagman commented Feb 10, 2022 •
edited
Loading

Here's a led run: https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/magder_google.com/af6dcdfeb5944e5d9b977d7d8d9425c61b920f931049cdc368da8046e5560806/+/build.proto?server=chromium-swarm.appspot.com

I expect this to fail until #98165 is fixed, we just need it to actually run the test without an Xcode infra failure. Then I can rebase #98171 onto this to see it actually pass.

@jmagman
Copy link
Member Author

jmagman commented Feb 10, 2022

Test failed as expected as in #98165, but not on any Xcode on infra issues.
Ready to merge with LGTM to rebase that fix and reopen the tree.

@jmagman
Copy link
Member Author

jmagman commented Feb 10, 2022

Merging on red.

@jmagman jmagman merged commit c1c96ef into flutter:master Feb 10, 2022
@jmagman jmagman deleted the lint-properties branch February 10, 2022 21:23
@jmagman jmagman mentioned this pull request Feb 10, 2022
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2022
@engine-flutter-autoroll
c1c96ef Override OS and Xcode version for plugin_lint_mac (flutter/fl…
ca7d6fd 
…utter#98210)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 10, 2022
@engine-flutter-autoroll
c1c96ef Override OS and Xcode version for plugin_lint_mac (flutter/fl…
670e658 
…utter#98210)
@jmagman jmagman mentioned this pull request Feb 10, 2022
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2022
@engine-flutter-autoroll
c1c96ef Override OS and Xcode version for plugin_lint_mac (flutter/fl…
7a6c134 
…utter#98210)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 10, 2022
@engine-flutter-autoroll
c1c96ef Override OS and Xcode version for plugin_lint_mac (flutter/fl…
8ae9a70 
…utter#98210)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
c1c96ef Override OS and Xcode version for plugin_lint_mac (flutter/fl…
64fa56c 
…utter#98210)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
c1c96ef Override OS and Xcode version for plugin_lint_mac (flutter/fl…
c78d771 
…utter#98210)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
c1c96ef Override OS and Xcode version for plugin_lint_mac (flutter/fl…
735b530 
…utter#98210)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
c1c96ef Override OS and Xcode version for plugin_lint_mac (flutter/fl…
adff89d 
…utter#98210)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
c1c96ef Override OS and Xcode version for plugin_lint_mac (flutter/fl…
5df2efb 
…utter#98210)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
c1c96ef Override OS and Xcode version for plugin_lint_mac (flutter/fl…
f2ac94a 
…utter#98210)
@keyonghan keyonghan mentioned this pull request Feb 11, 2022
Closed
@jmagman jmagman mentioned this pull request Feb 11, 2022
Merged
8 tasks
@jmagman jmagman added the a: tests "flutter test", flutter_test, or one of our tests label Feb 18, 2022
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@jmagman @clocksmith
Override OS and Xcode version for plugin_lint_mac (flutter#98210)
016cff9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyHillers CaseyHillers CaseyHillers left review comments

@zanderso zanderso zanderso approved these changes

@keyonghan keyonghan Awaiting requested review from keyonghan

Assignees

@jmagman jmagman

Labels
a: tests "flutter test", flutter_test, or one of our tests team-infra Owned by Infrastructure team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmagman @keyonghan @CaseyHillers @zanderso