Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove deprecated FlatButton #98545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 11, 2022
Merged

Remove deprecated FlatButton #98545

merged 5 commits into from
Apr 11, 2022

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Feb 16, 2022

This removes the deprecated FlatButton widget.

This deprecated property has reached end of life after the release of Flutter 2.10

Part of #98537
For the full list of deprecations being removed in this batch, see flutter.dev/go/deprecations-removed-after-2-10

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. c: API break Backwards-incompatible API changes a: quality A truly polished experience c: tech-debt Technical debt, code quality, testing, etc. labels Feb 16, 2022
@flutter-dashboard flutter-dashboard bot added the f: material design flutter/packages/flutter/material repository. label Feb 16, 2022
@Piinks
Copy link
Contributor Author

Piinks commented Mar 3, 2022

Still migrating customers here.

@flutter-dashboard

This comment was marked as outdated.

Sign in to view
@Piinks Piinks changed the title [WIP] Remove deprecated FlatButton Remove deprecated FlatButton Apr 11, 2022
@flutter-dashboard flutter-dashboard bot added the a: internationalization Supporting other languages or locales. (aka i18n) label Apr 11, 2022
@Piinks Piinks requested a review from HansMuller April 11, 2022 20:12
HansMuller
HansMuller approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Piinks Piinks merged commit ff5e27f into flutter:master Apr 11, 2022
This was referenced Apr 11, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 11, 2022
@engine-flutter-autoroll
ff5e27f Remove deprecated FlatButton (flutter/flutter#98545)
7f8bfc2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2022
@engine-flutter-autoroll
ff5e27f Remove deprecated FlatButton (flutter/flutter#98545)
9cae733
This was referenced Apr 11, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2022
@engine-flutter-autoroll
ff5e27f Remove deprecated FlatButton (flutter/flutter#98545)
1f2cba4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 11, 2022
@engine-flutter-autoroll
ff5e27f Remove deprecated FlatButton (flutter/flutter#98545)
c079a23
@Piinks Piinks mentioned this pull request Apr 13, 2022
Merged
3 tasks
This was referenced May 6, 2022
Closed
Merged
@vitalsh vitalsh mentioned this pull request Aug 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansMuller HansMuller HansMuller approved these changes

Assignees
No one assigned
Labels
a: internationalization Supporting other languages or locales. (aka i18n) a: quality A truly polished experience c: API break Backwards-incompatible API changes c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Piinks @HansMuller