💡 Improve comment of _transparentImage

ValentinVignal · ValentinVignal · commit 03c48da555ff · 2021-10-28T20:29:29.000+08:00
diff --git a/packages/google_sign_in/google_sign_in/lib/widgets.dart b/packages/google_sign_in/google_sign_in/lib/widgets.dart
@@ -114,7 +114,7 @@ class GoogleUserCircleAvatar extends StatelessWidget {
   }
 }
 
-/// This is an transparent 1x1 gif image
+/// This is an transparent 1x1 gif image.
 final Uint8List _transparentImage = Uint8List.fromList(
   [
     0x47, 0x49, 0x46, 0x38, 0x39, 0x61, 0x01, 0x00, 0x01, 0x00, 0x80, 0x00, //
diff --git a/packages/google_sign_in/google_sign_in/test/widgets_test.dart b/packages/google_sign_in/google_sign_in/test/widgets_test.dart
@@ -49,7 +49,10 @@ class _MockHttpRequest extends Fake implements HttpClientRequest {
   }
 }
 
-/// This is an transparent 1x1 gif image
+/// Arbitrary valid image returned by the [_MockHttpResponse].
+///
+/// This is an transparent 1x1 gif image.
+/// It doesn't have to match the placeholder used in [GoogleUserCircleAvatar]
 final Uint8List _transparentImage = Uint8List.fromList(
   [
     0x47, 0x49, 0x46, 0x38, 0x39, 0x61, 0x01, 0x00, 0x01, 0x00, 0x80, 0x00, //
@@ -60,7 +63,7 @@ final Uint8List _transparentImage = Uint8List.fromList(
 );
 
 /// A mocked [HttpClientResponse] which is empty and has a [statusCode] of 200
-/// and returns a 1x1 transparent image.
+/// and returns valid image.
 class _MockHttpResponse extends Fake implements HttpClientResponse {
   final Stream<Uint8List> _delegate =
       Stream<Uint8List>.value(_transparentImage);

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ class GoogleUserCircleAvatar extends StatelessWidget {`
`114`	`114`	`}`
`115`	`115`	`}`
`116`	`116`
`117`		`-/// This is an transparent 1x1 gif image`
	`117`	`+/// This is an transparent 1x1 gif image.`
`118`	`118`	`final Uint8List _transparentImage = Uint8List.fromList(`
`119`	`119`	`[`
`120`	`120`	`0x47, 0x49, 0x46, 0x38, 0x39, 0x61, 0x01, 0x00, 0x01, 0x00, 0x80, 0x00, //`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,10 @@ class _MockHttpRequest extends Fake implements HttpClientRequest {`
`49`	`49`	`}`
`50`	`50`	`}`
`51`	`51`
`52`		`-/// This is an transparent 1x1 gif image`
	`52`	`+/// Arbitrary valid image returned by the [_MockHttpResponse].`
	`53`	`+///`
	`54`	`+/// This is an transparent 1x1 gif image.`
	`55`	`+/// It doesn't have to match the placeholder used in [GoogleUserCircleAvatar]`
`53`	`56`	`final Uint8List _transparentImage = Uint8List.fromList(`
`54`	`57`	`[`
`55`	`58`	`0x47, 0x49, 0x46, 0x38, 0x39, 0x61, 0x01, 0x00, 0x01, 0x00, 0x80, 0x00, //`
`@@ -60,7 +63,7 @@ final Uint8List _transparentImage = Uint8List.fromList(`
`60`	`63`	`);`
`61`	`64`
`62`	`65`	`/// A mocked [HttpClientResponse] which is empty and has a [statusCode] of 200`
`63`		`-/// and returns a 1x1 transparent image.`
	`66`	`+/// and returns valid image.`
`64`	`67`	`class _MockHttpResponse extends Fake implements HttpClientResponse {`
`65`	`68`	`final Stream<Uint8List> _delegate =`
`66`	`69`	`Stream<Uint8List>.value(_transparentImage);`