From ac798e7a7edfac7be292d01690fe602a0c8dab04 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pol=20Batll=C3=B3?= Date: Fri, 22 Dec 2017 10:14:08 +0100 Subject: [PATCH 1/6] Fix for APNS not being correctly registered, which makes notifications fail when uninstalling and re-installing the application. --- .../ios/Classes/FirebaseMessagingPlugin.m | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/firebase_messaging/ios/Classes/FirebaseMessagingPlugin.m b/packages/firebase_messaging/ios/Classes/FirebaseMessagingPlugin.m index fbf8becfe3af..809f38178c6a 100644 --- a/packages/firebase_messaging/ios/Classes/FirebaseMessagingPlugin.m +++ b/packages/firebase_messaging/ios/Classes/FirebaseMessagingPlugin.m @@ -137,7 +137,14 @@ - (bool)application:(UIApplication *)application - (void)application:(UIApplication *)application didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken { - [_channel invokeMethod:@"onToken" arguments:[[FIRInstanceID instanceID] token]]; + +#ifdef DEBUG + [[FIRMessaging messaging] setAPNSToken:deviceToken type:FIRMessagingAPNSTokenTypeSandbox]; +#else + [[FIRMessaging messaging] setAPNSToken:deviceToken type:FIRMessagingAPNSTokenTypeProd]; +#endif + + [_channel invokeMethod:@"onToken" arguments:[[FIRInstanceID instanceID] token]]; } - (void)application:(UIApplication *)application From b5f5942e23f8d3864a63be7887daecfbc95c09fe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pol=20Batll=C3=B3?= Date: Thu, 11 Jan 2018 10:32:18 +0100 Subject: [PATCH 2/6] Resolving Formatting Issues --- .../ios/Classes/FirebaseMessagingPlugin.m | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/firebase_messaging/ios/Classes/FirebaseMessagingPlugin.m b/packages/firebase_messaging/ios/Classes/FirebaseMessagingPlugin.m index 809f38178c6a..2f59002961d8 100644 --- a/packages/firebase_messaging/ios/Classes/FirebaseMessagingPlugin.m +++ b/packages/firebase_messaging/ios/Classes/FirebaseMessagingPlugin.m @@ -137,14 +137,13 @@ - (bool)application:(UIApplication *)application - (void)application:(UIApplication *)application didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken { - #ifdef DEBUG - [[FIRMessaging messaging] setAPNSToken:deviceToken type:FIRMessagingAPNSTokenTypeSandbox]; + [[FIRMessaging messaging] setAPNSToken:deviceToken type:FIRMessagingAPNSTokenTypeSandbox]; #else - [[FIRMessaging messaging] setAPNSToken:deviceToken type:FIRMessagingAPNSTokenTypeProd]; + [[FIRMessaging messaging] setAPNSToken:deviceToken type:FIRMessagingAPNSTokenTypeProd]; #endif - [_channel invokeMethod:@"onToken" arguments:[[FIRInstanceID instanceID] token]]; + [_channel invokeMethod:@"onToken" arguments:[[FIRInstanceID instanceID] token]]; } - (void)application:(UIApplication *)application From c1cd497be0cdb9efd0c3368cd153c30809f5fce1 Mon Sep 17 00:00:00 2001 From: Collin Jackson Date: Fri, 12 Jan 2018 17:43:32 -0800 Subject: [PATCH 3/6] Update CHANGELOG.md --- packages/firebase_messaging/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/firebase_messaging/CHANGELOG.md b/packages/firebase_messaging/CHANGELOG.md index 446c533b821e..c21db69dd6d1 100644 --- a/packages/firebase_messaging/CHANGELOG.md +++ b/packages/firebase_messaging/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.1.1 + +* Fix for APNS not being correctly registered on iOS when reinstalling application. + ## 0.1.0 * **Breaking change**. Upgraded to Gradle 4.1 and Android Studio Gradle plugin From 577749ff1a271cabb81135ab0c7967c46390ef7b Mon Sep 17 00:00:00 2001 From: Collin Jackson Date: Fri, 12 Jan 2018 17:43:43 -0800 Subject: [PATCH 4/6] Update pubspec.yaml --- packages/firebase_messaging/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/firebase_messaging/pubspec.yaml b/packages/firebase_messaging/pubspec.yaml index a15ee4a61d36..8db7ee27ee1a 100644 --- a/packages/firebase_messaging/pubspec.yaml +++ b/packages/firebase_messaging/pubspec.yaml @@ -3,7 +3,7 @@ name: firebase_messaging description: Firebase Cloud Messaging plugin for Flutter applications. author: Flutter Team homepage: https://github.com/flutter/plugins/tree/master/packages/firebase_messaging -version: 0.1.0 +version: 0.1.1 flutter: plugin: From aa172a8f7037cb396be8c696eb2760a76fb1d22b Mon Sep 17 00:00:00 2001 From: Collin Jackson Date: Fri, 12 Jan 2018 17:45:09 -0800 Subject: [PATCH 5/6] Update AUTHORS --- AUTHORS | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS b/AUTHORS index ff28ac316165..20d1fe266bca 100644 --- a/AUTHORS +++ b/AUTHORS @@ -6,3 +6,4 @@ Google Inc. German Saprykin Benjamin Sauer +Pol Batlló From 673d689999249e3deac4b1c9cfe0bc4bfb42b8b3 Mon Sep 17 00:00:00 2001 From: Collin Jackson Date: Fri, 12 Jan 2018 17:46:21 -0800 Subject: [PATCH 6/6] Update pubspec.yaml --- packages/firebase_messaging/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/firebase_messaging/pubspec.yaml b/packages/firebase_messaging/pubspec.yaml index 74d793a8481a..753b2e00cfe4 100644 --- a/packages/firebase_messaging/pubspec.yaml +++ b/packages/firebase_messaging/pubspec.yaml @@ -3,7 +3,7 @@ description: Flutter plugin for Firebase Cloud Messaging, a cross-platform messaging solution that lets you reliably deliver messages on Android and iOS. author: Flutter Team homepage: https://github.com/flutter/plugins/tree/master/packages/firebase_messaging -version: 0.1.1 +version: 0.1.2 flutter: plugin: