From 421d6b40863a44dcc226a97e3adfcc28b319700d Mon Sep 17 00:00:00 2001 From: Anniek Date: Wed, 21 Oct 2020 15:19:09 +0200 Subject: [PATCH 1/5] Added information of video not working correctly on Android emulators to `README.md`. --- packages/camera/CHANGELOG.md | 4 ++++ packages/camera/README.md | 4 ++++ packages/camera/pubspec.yaml | 2 +- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/packages/camera/CHANGELOG.md b/packages/camera/CHANGELOG.md index bd075f490e90..833a604fe6d7 100644 --- a/packages/camera/CHANGELOG.md +++ b/packages/camera/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.5.8+11 + +* Added information of video not working correctly on Android emulators to `README.md`. + ## 0.5.8+10 * Suppress the `deprecated_member_use` warning in the example app for `ScaffoldMessenger.showSnackBar`. diff --git a/packages/camera/README.md b/packages/camera/README.md index fbd73929e6de..b3d3e3953b18 100644 --- a/packages/camera/README.md +++ b/packages/camera/README.md @@ -41,6 +41,10 @@ Change the minimum Android sdk version to 21 (or higher) in your `android/app/bu minSdkVersion 21 ``` +Important to note is that the `MediaRecorder` class is not working properly on emulators. This makes +that when a video is recorded with sound enabled, the duration won't be correct and you will only +see the first frame. + ### Example Here is a small example flutter app displaying a full screen camera preview. diff --git a/packages/camera/pubspec.yaml b/packages/camera/pubspec.yaml index b581135967f1..7a2b187098ef 100644 --- a/packages/camera/pubspec.yaml +++ b/packages/camera/pubspec.yaml @@ -2,7 +2,7 @@ name: camera description: A Flutter plugin for getting information about and controlling the camera on Android and iOS. Supports previewing the camera feed, capturing images, capturing video, and streaming image buffers to dart. -version: 0.5.8+10 +version: 0.5.8+11 homepage: https://github.com/flutter/plugins/tree/master/packages/camera From c296a269b6b1d92c3150f4c6feb0ef235e948abb Mon Sep 17 00:00:00 2001 From: valconetti Date: Thu, 22 Oct 2020 13:24:20 +0200 Subject: [PATCH 2/5] Changed up the text and added a link --- packages/camera/README.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/camera/README.md b/packages/camera/README.md index b3d3e3953b18..734fa34ea971 100644 --- a/packages/camera/README.md +++ b/packages/camera/README.md @@ -41,9 +41,7 @@ Change the minimum Android sdk version to 21 (or higher) in your `android/app/bu minSdkVersion 21 ``` -Important to note is that the `MediaRecorder` class is not working properly on emulators. This makes -that when a video is recorded with sound enabled, the duration won't be correct and you will only -see the first frame. +Important to note is that the `MediaRecorder` class is not working properly on emulators, as stated in the documentation: https://developer.android.com/reference/android/media/MediaRecorder. Specifically when recording a video with sound enabled and try to play it back, the duration won't be correct and you will only see the first frame. ### Example From 68e0251ffe5df15fa457a2e1bbb954f2b556f18f Mon Sep 17 00:00:00 2001 From: valconetti Date: Thu, 22 Oct 2020 13:28:58 +0200 Subject: [PATCH 3/5] Version fix --- packages/camera/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/camera/pubspec.yaml b/packages/camera/pubspec.yaml index 7a2b187098ef..827ddc450fce 100644 --- a/packages/camera/pubspec.yaml +++ b/packages/camera/pubspec.yaml @@ -2,7 +2,7 @@ name: camera description: A Flutter plugin for getting information about and controlling the camera on Android and iOS. Supports previewing the camera feed, capturing images, capturing video, and streaming image buffers to dart. -version: 0.5.8+11 +version: 0.5.8+12 homepage: https://github.com/flutter/plugins/tree/master/packages/camera From a87441bb13f650cdc74c113d5876cc93550941e4 Mon Sep 17 00:00:00 2001 From: Anniek Date: Fri, 23 Oct 2020 10:08:48 +0200 Subject: [PATCH 4/5] Update packages/camera/README.md Co-authored-by: Maurits van Beusekom --- packages/camera/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/camera/README.md b/packages/camera/README.md index 839dad4b187f..7c6a593d5e73 100644 --- a/packages/camera/README.md +++ b/packages/camera/README.md @@ -41,7 +41,7 @@ Change the minimum Android sdk version to 21 (or higher) in your `android/app/bu minSdkVersion 21 ``` -Important to note is that the `MediaRecorder` class is not working properly on emulators, as stated in the documentation: https://developer.android.com/reference/android/media/MediaRecorder. Specifically when recording a video with sound enabled and try to play it back, the duration won't be correct and you will only see the first frame. +Important to note is that the `MediaRecorder` class is not working properly on emulators, as stated in the documentation: https://developer.android.com/reference/android/media/MediaRecorder. Specifically when recording a video with sound enabled and trying to play it back, the duration won't be correct and you will only see the first frame. ### Handling Lifecycle states From c2e01f4dfe46b25c46167fbff1fc8e22e5877e8a Mon Sep 17 00:00:00 2001 From: Maurits van Beusekom Date: Fri, 23 Oct 2020 20:25:38 +0200 Subject: [PATCH 5/5] Improve grammar as suggested Co-authored-by: Maurice Parrish --- packages/camera/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/camera/README.md b/packages/camera/README.md index 7c6a593d5e73..39d3ed88abea 100644 --- a/packages/camera/README.md +++ b/packages/camera/README.md @@ -41,7 +41,7 @@ Change the minimum Android sdk version to 21 (or higher) in your `android/app/bu minSdkVersion 21 ``` -Important to note is that the `MediaRecorder` class is not working properly on emulators, as stated in the documentation: https://developer.android.com/reference/android/media/MediaRecorder. Specifically when recording a video with sound enabled and trying to play it back, the duration won't be correct and you will only see the first frame. +It's important to note that the `MediaRecorder` class is not working properly on emulators, as stated in the documentation: https://developer.android.com/reference/android/media/MediaRecorder. Specifically, when recording a video with sound enabled and trying to play it back, the duration won't be correct and you will only see the first frame. ### Handling Lifecycle states