From b9a0f499006abf1c5a6a89abaf67fbb78f9531e1 Mon Sep 17 00:00:00 2001 From: russellwheatley Date: Tue, 12 Jan 2021 15:28:32 +0000 Subject: [PATCH 1/6] tests(video_player): initial test coverage file() api --- .../integration_test/video_player_test.dart | 23 ++++++++++++++++++- .../video_player/example/pubspec.yaml | 1 + 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/packages/video_player/video_player/example/integration_test/video_player_test.dart b/packages/video_player/video_player/example/integration_test/video_player_test.dart index 9e273e02dc4d..ad8a2805a8b0 100644 --- a/packages/video_player/video_player/example/integration_test/video_player_test.dart +++ b/packages/video_player/video_player/example/integration_test/video_player_test.dart @@ -6,12 +6,15 @@ // https://github.com/flutter/flutter/issues/71379 // @dart = 2.9 import 'dart:async'; - +import 'dart:io'; import 'package:flutter/foundation.dart'; import 'package:flutter/material.dart'; import 'package:integration_test/integration_test.dart'; import 'package:flutter_test/flutter_test.dart'; import 'package:video_player/video_player.dart'; +import 'package:path_provider/path_provider.dart'; +import 'package:flutter/services.dart' show rootBundle; +import 'dart:typed_data'; const Duration _playDuration = Duration(seconds: 1); @@ -162,5 +165,23 @@ void main() { await tester.pumpAndSettle(); expect(_controller.value.isPlaying, true); }, skip: kIsWeb); // Web does not support local assets. + + testWidgets('test video player using static file() method as constructor', + (WidgetTester tester) async { + String tempDir = (await getTemporaryDirectory()).path; + ByteData bytes = await rootBundle.load('assets/Butterfly-209.mp4'); + + File file = File('$tempDir/Butterfly-209.mp4'); + await file.writeAsBytes(bytes.buffer.asInt8List()); + + VideoPlayerController fileController = VideoPlayerController.file(file); + await fileController.initialize(); + + await fileController.play(); + expect(fileController.value.isPlaying, true); + + await fileController.pause(); + expect(fileController.value.isPlaying, false); + }, skip: kIsWeb); }); } diff --git a/packages/video_player/video_player/example/pubspec.yaml b/packages/video_player/video_player/example/pubspec.yaml index fb18d8b75efa..7b7cb786194d 100644 --- a/packages/video_player/video_player/example/pubspec.yaml +++ b/packages/video_player/video_player/example/pubspec.yaml @@ -18,6 +18,7 @@ dev_dependencies: path: ../../../integration_test test: any pedantic: ^1.10.0-nullsafety.1 + path_provider: ^1.6.27 flutter: uses-material-design: true From 4c5b313797bef729cc3dc2b2df73a646cd5d03bd Mon Sep 17 00:00:00 2001 From: russellwheatley Date: Tue, 12 Jan 2021 15:36:00 +0000 Subject: [PATCH 2/6] chore(video_player): update changelog --- packages/video_player/video_player/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/video_player/video_player/CHANGELOG.md b/packages/video_player/video_player/CHANGELOG.md index f9bae8dee6e1..18887ce79c74 100644 --- a/packages/video_player/video_player/CHANGELOG.md +++ b/packages/video_player/video_player/CHANGELOG.md @@ -1,3 +1,7 @@ +## 2.0.0-nullsafety.8 + +* Integration test for `VideoPlayerController.file()`. + ## 2.0.0-nullsafety.7 * Update the example app: remove the deprecated `RaisedButton` and `FlatButton` widgets. From e8b4bb54b063fd6f1b1391e34651d4d1662b2476 Mon Sep 17 00:00:00 2001 From: russellwheatley Date: Tue, 12 Jan 2021 16:07:55 +0000 Subject: [PATCH 3/6] chore(video_player): update version --- packages/video_player/video_player/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/video_player/video_player/pubspec.yaml b/packages/video_player/video_player/pubspec.yaml index e4694195ebde..72fb54b125ea 100644 --- a/packages/video_player/video_player/pubspec.yaml +++ b/packages/video_player/video_player/pubspec.yaml @@ -4,7 +4,7 @@ description: Flutter plugin for displaying inline video with other Flutter # 0.10.y+z is compatible with 1.0.0, if you land a breaking change bump # the version to 2.0.0. # See more details: https://github.com/flutter/flutter/wiki/Package-migration-to-1.0.0 -version: 2.0.0-nullsafety.7 +version: 2.0.0-nullsafety.8 homepage: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player flutter: From eb42103f21e047f323c4693bba1a8af43b7a9a8b Mon Sep 17 00:00:00 2001 From: russellwheatley Date: Tue, 12 Jan 2021 16:18:03 +0000 Subject: [PATCH 4/6] format(video_player): ran formatter --- .../example/integration_test/video_player_test.dart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/video_player/video_player/example/integration_test/video_player_test.dart b/packages/video_player/video_player/example/integration_test/video_player_test.dart index ad8a2805a8b0..6f3ecde26948 100644 --- a/packages/video_player/video_player/example/integration_test/video_player_test.dart +++ b/packages/video_player/video_player/example/integration_test/video_player_test.dart @@ -176,10 +176,10 @@ void main() { VideoPlayerController fileController = VideoPlayerController.file(file); await fileController.initialize(); - + await fileController.play(); expect(fileController.value.isPlaying, true); - + await fileController.pause(); expect(fileController.value.isPlaying, false); }, skip: kIsWeb); From 9cbf1efe857cbe1ea1f0b431a173a5c307e187eb Mon Sep 17 00:00:00 2001 From: stuartmorgan Date: Tue, 10 Aug 2021 10:28:35 -0700 Subject: [PATCH 5/6] Update video_player_test.dart --- .../example/integration_test/video_player_test.dart | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/packages/video_player/video_player/example/integration_test/video_player_test.dart b/packages/video_player/video_player/example/integration_test/video_player_test.dart index 7b0fcade9d71..dd481c65b37e 100644 --- a/packages/video_player/video_player/example/integration_test/video_player_test.dart +++ b/packages/video_player/video_player/example/integration_test/video_player_test.dart @@ -4,14 +4,15 @@ import 'dart:async'; import 'dart:io'; +import 'dart:typed_data'; + import 'package:flutter/foundation.dart'; import 'package:flutter/material.dart'; -import 'package:integration_test/integration_test.dart'; +import 'package:flutter/services.dart' show rootBundle; import 'package:flutter_test/flutter_test.dart'; -import 'package:video_player/video_player.dart'; +import 'package:integration_test/integration_test.dart'; import 'package:path_provider/path_provider.dart'; -import 'package:flutter/services.dart' show rootBundle; -import 'dart:typed_data'; +import 'package:video_player/video_player.dart'; const Duration _playDuration = Duration(seconds: 1); From cb7c0677a5ee4470db3c90ec5af6546b45a4e59b Mon Sep 17 00:00:00 2001 From: Stuart Morgan Date: Thu, 4 Nov 2021 13:57:30 -0400 Subject: [PATCH 6/6] Update path_provider dependency --- packages/video_player/video_player/example/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/video_player/video_player/example/pubspec.yaml b/packages/video_player/video_player/example/pubspec.yaml index d99223218b24..ce1787e2b427 100644 --- a/packages/video_player/video_player/example/pubspec.yaml +++ b/packages/video_player/video_player/example/pubspec.yaml @@ -24,7 +24,7 @@ dev_dependencies: sdk: flutter integration_test: sdk: flutter - path_provider: ^1.6.27 + path_provider: ^2.0.6 pedantic: ^1.10.0 test: any