[webview_flutter] Add an option to set the background color of the webview#3431
[webview_flutter] Add an option to set the background color of the webview#3431fluttergithubbot merged 30 commits intoflutter:masterfrom e-adrien:webview-transparent-background
Conversation
|
So close to have this feature ... waiting for month as others !!! Hope this merge will be accepted and in the next Webview version ! |
|
There are conflicts, seems @e-adrien you need to rebase again. 🤪 |
|
@crizant done 😄 I'll try to rebase it more regularly 😅 |
|
Any updates? |
We can't currently run the Android integration tests for PRs from non-contributors in presubmit, unfortunately. It sounds like this is ready for another review round then? We're currently doing a significant restructuring of the webview plugin implementation (moving the platform channel boundary much closer to the OS API), so I'll hold off for the moment, but once that's complete we can move forward with this. Since the tests here are integration tests, I don't expect there to actually be much impact on the PR, just some adjustment to the |
Okay, no problem. It was just to be sure that I didn't do something wrong.
No problem. I'll check this PR once a week to see if it needs rebasing until we can move forward. |
|
I pushed a merge that should update the PR for the new Dart-based Android implementation (feel free to replace with a rebase instead if that's your preferred workflow). |
There was a problem hiding this comment.
I think this is pretty much good to go, other than needing a test of the change to the method channel in the platform interface package, and of the background color parameter in the app-facing package. Both should be simple Dart tests that the values are passed through to the next layer as expected.
If you split out the platform interface change now (with that test added), and we can start getting this incrementally reviewed and landed.
|
FYI the analyzer issue you are hitting is unrelated to your change; I just landed a fix for it. |
|
The individual components have all landed (the Android implementation will auto-publish once the post-submit tests finish), so this can now be reduced down to just the |
Thanks. I will open a PR when the android package will be published. |
This PR add an option to set a transparent background for the webview.
There are already 2 outdated PR for the same feature :
I took the previous PR made by @crizant and rebase it.
It fixes this issue :