Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[path_provider] Remove use of deprecated pedantic package #4764

Merged
merged 1 commit into from
Feb 10, 2022
Merged

[path_provider] Remove use of deprecated pedantic package #4764

merged 1 commit into from
Feb 10, 2022

Conversation

robert-ancell
Copy link
Contributor

@robert-ancell robert-ancell commented Feb 8, 2022 •
edited
Loading

Remove use of deprecated pedantic package

No version change: Removing cruft
No CHANGELOG change: Removing cruft

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@robert-ancell
Copy link
Contributor Author

Not sure if this change should be part of a release or not. The only user-visible change is in the examples, but that doesn't seem significant.

stuartmorgan-g
stuartmorgan-g suggested changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use lints in this repository. These lines can all just be straight up removed; pedantic was there from when we used the legacy repo analysis options, and I just forgot to remove the dependency when removing the legacy options.

@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Feb 8, 2022 •
edited
Loading

Not sure if this change should be part of a release or not.

Since you'll just be removing a cruft line from dev dependencies, you can use the "No version change" and "No CHANGELOG change" overrides in the PR description. (You'll need to update it before you push so "publishable" passes.)

@robert-ancell robert-ancell changed the title [path_provider] Switch from deprecated pedantic package to lints [path_provider] Remove use of deprecated pedantic package Feb 8, 2022
@robert-ancell
[path_provider] Remove use of deprecated pedantic package
34a316f 
This package is deprectated and this repository doesn't use the replacement (lints).
stuartmorgan-g
stuartmorgan-g approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stuartmorgan-g stuartmorgan-g added waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. last mile labels Feb 10, 2022
@fluttergithubbot fluttergithubbot merged commit 09ab5d7 into flutter:main Feb 10, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
09ab5d74c [path_provider] Remove use of deprecated pedantic package (f…
fc2744c 
…lutter/plugins#4764)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
09ab5d74c [path_provider] Remove use of deprecated pedantic package (f…
412186d 
…lutter/plugins#4764)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 14, 2022
@engine-flutter-autoroll
09ab5d74c [path_provider] Remove use of deprecated pedantic package (f…
8412478 
…lutter/plugins#4764)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Assignees
No one assigned
Labels
p: path_provider platform-android platform-ios platform-linux platform-macos platform-windows waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robert-ancell @stuartmorgan-g @fluttergithubbot