This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[url_launcher] Major version bump for desktop Dart-based url_launcher implementations #4777
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4719 converted the url_launcher implementations to Dart-based versions. This should have been completely transparent to clients, but there is a latent bug in
url_launcher
where thedefault_package
entries for Linux, macOS, and Windows are incorrect. This went unnoticed until now because currently the only client-facing effect ofdefault_package
is in resolving which implementation to run Dart registration for. Because of the typos in thedefault_package
entries, the resolution in theflutter
tool doesn't recognize the registration for these packages as needing to run, causing them to be broken at runtime.The affected versions have been retracted to fix the breakage in the short term. This is PR is the first half of the long-term fix; it re-releases them as a major version bump so that existing versions of
url_launcher
will not pick them up. Once they are published, a follow-up PR will updateurl_launcher
to fix the typos and relax the version constraints for the dependencies on these implementation packages to allow 2.x or 3.x. (In theory this could be one PR, but doing it as two ensures that we get real testing on theurl_launcher
change, so is safer.)Part of a long-term fix for flutter/flutter#98097
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).