[url_launcher] Support new desktop implementation versions #4779
Conversation
Fixes default_package typos for the Linux, macOS, and Windows implementations, allowing Dart registration to work correctly. Updates the constraints to allow the new major versions of those packages, which have major version bumps only to prevent older versions of `url_launcher` from picking them up, since their Dart registration won't work prior to this fix. Long-term fix for flutter/flutter#98097
|
Note: I'm posting this for review now, but before landing we should wait until the url_launcher_* packages have been published and then re-run the Linux, macOS, and Windows tests so that they are being tested against the 3.0 versions. This initial run will be against the 2.0.x versions since at time of posting the 3.x's haven't been published. |
|
Re-run passed |
| output, | ||
| containsAllInOrder(<Matcher>[ | ||
| contains( | ||
| '"plugin_b_android" is not an expected implementation name for "plugin_a"'), |
| if (!defaultPackage.startsWith('${packageName}_')) { | ||
| return '"$defaultPackage" is not an expected implementation name ' | ||
| 'for "$packageName"'; | ||
| } |
There was a problem hiding this comment.
Instead of this, why not check that defaultPackage is contained as a dependency of the plugin?
That way we could still endorse packages that have a name that doesn't start with packageName (because it might be taken, or because somebody else started the plugin before this rule went into effect?), and have some validation that we're using the correct value for the name of the dependency?
There was a problem hiding this comment.
Instead of this, why not check that defaultPackage is contained as a dependency of the plugin?
That's the very next block of code :)
That way we could still endorse packages that have a name that doesn't start with packageName (because it might be taken, or because somebody else started the plugin before this rule went into effect?)
The reason I did this in addition is that I think it's useful to enforce prefix naming; even if the name we might normally use is taken, I think we should avoid the collision via suffix changes rather than breaking our core naming pattern.
There was a problem hiding this comment.
That's the very next block of code :)
🤦 Gonna grab some coffee, my attention span is shrinking dangerously!
even if the name we might normally use is taken, I think we should avoid the collision via suffix changes rather than breaking our core naming pattern.
Yeah, we've had to do it with some "_for_web" packages. I was thinking more on the case that somebody else has a plugin for some platform and they've already published it as: "contoso_better_url_launcher_for_windows" or similar, and then we want to make that the endorsed implementation. That'll probably never happen, though :P
Fixes default_package typos for the Linux, macOS, and Windows
implementations, allowing Dart registration to work correctly. Updates
the constraints to allow the new major versions of those packages, which
have major version bumps only to prevent older versions of
url_launcherfrom picking them up, since their Dart registration won'twork prior to this fix.
Also adds repository tooling to prevent this kind of typo from slipping
in again.
Long-term fix for flutter/flutter#98097
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).