From 5f2d48bb3331a1edc8b69382c0b47a1e068cc200 Mon Sep 17 00:00:00 2001 From: Kevin Moore Date: Tue, 25 Oct 2022 22:14:47 -0700 Subject: [PATCH 1/2] Fix strict language checks The strict- values are meant to be used via the language key See https://dart.dev/guides/language/analysis-options --- analysis_options.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/analysis_options.yaml b/analysis_options.yaml index 98352af415de..b12af6cf11e6 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -22,7 +22,7 @@ # repository. analyzer: - strong-mode: + language: strict-casts: true strict-raw-types: true errors: From a3ac841692f9ea5944b39a63a14e0093c96035f7 Mon Sep 17 00:00:00 2001 From: Stuart Morgan Date: Wed, 26 Oct 2022 10:23:34 -0400 Subject: [PATCH 2/2] Fix analysis --- .../google_sign_in_web/lib/src/generated/gapiauth2.dart | 2 +- .../test/fakes/fake_storekit_platform.dart | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/google_sign_in/google_sign_in_web/lib/src/generated/gapiauth2.dart b/packages/google_sign_in/google_sign_in_web/lib/src/generated/gapiauth2.dart index e1721668f41f..f474e0d00f69 100644 --- a/packages/google_sign_in/google_sign_in_web/lib/src/generated/gapiauth2.dart +++ b/packages/google_sign_in/google_sign_in_web/lib/src/generated/gapiauth2.dart @@ -12,7 +12,7 @@ // https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/gapi.auth2 -// ignore_for_file: public_member_api_docs, unused_element, non_constant_identifier_names, sort_constructors_first, always_specify_types +// ignore_for_file: public_member_api_docs, unused_element, non_constant_identifier_names, sort_constructors_first, always_specify_types, strict_raw_type @JS() library gapiauth2; diff --git a/packages/in_app_purchase/in_app_purchase_storekit/test/fakes/fake_storekit_platform.dart b/packages/in_app_purchase/in_app_purchase_storekit/test/fakes/fake_storekit_platform.dart index e64876deccba..e6b9696c8cb1 100644 --- a/packages/in_app_purchase/in_app_purchase_storekit/test/fakes/fake_storekit_platform.dart +++ b/packages/in_app_purchase/in_app_purchase_storekit/test/fakes/fake_storekit_platform.dart @@ -176,7 +176,7 @@ class FakeStoreKitPlatform { if (call.arguments['applicationUsername'] == 'userWithDiscount') { if (call.arguments['paymentDiscount'] != null) { final Map discountArgument = - call.arguments['paymentDiscount']; + call.arguments['paymentDiscount'] as Map; discountReceived = discountArgument.cast(); } else { discountReceived = {};