Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update logger.dart #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 6, 2023
Merged

Update logger.dart #337

merged 3 commits into from
Feb 6, 2023

Conversation

@IvoB1987
Copy link
Contributor

@IvoB1987 IvoB1987 commented Jan 4, 2023 •
edited
Loading

Simplify the logger and fixes #328

Perondas
Perondas requested changes Feb 6, 2023
View reviewed changes
Copy link
Collaborator

@Perondas Perondas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your implementation broke multiple logs.

error - The method 'w' isn't defined for the type 'Log' - lib\src\sip_ua_helper.dart:65:11 - undefined_method
error - The method 'e' isn't defined for the type 'Log' - lib\src\sip_ua_helper.dart:80:11 - undefined_method
error - The method 'e' isn't defined for the type 'Log' - lib\src\transports\websocket_interface.dart:109:11 - undefined_method
error - The method 'e' isn't defined for the type 'Log' - lib\src\ua.dart:334:15 - undefined_method
error - The method 'e' isn't defined for the type 'Log' - lib\src\ua.dart:347:15 - undefined_method

Either return the static Log object or (preferably) replace them all with the logger static object.

@IvoB1987
Copy link
Contributor Author

IvoB1987 commented Feb 6, 2023

@Perondas you are right, my mistake. Personally I replaced all Log reference with logger earlier and I forgot about it being like that. I believe it was wrong to use Log anyway since every other place where something is logged uses logger. It was hard for me to see that the change was dependent on the Logger class since I have customised the sip_ua library on many other places as well in my project. I'm not really active on github and making pull requests is also a bit new to me. Personally I don't really feel like making the corrections for this pull requests, so feel free to edit it yourself, or just ignore it, whatever you prefer. I can't be bothered with it.

@Perondas Perondas merged commit 3114b8d into flutter-webrtc:master Feb 6, 2023
@IvoB1987 IvoB1987 deleted the patch-1 branch February 6, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Perondas Perondas Perondas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Default logger is broken in 0.5.3

2 participants

@IvoB1987 @Perondas