Allow await on helper start call #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the return value of start is void rather than Future<void> it is impossible to await it's completion because it has been flagged as async. Users choosing to allow the call to be completed asynchronously can simply ignore the Future<void> but those wanting to act after registration is complete cannot do so without this change.
Collaborator
|
Only saw this after doing the new release, I'll get it in with the next version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the return value of start is void rather than Future it is impossible to await it's completion because it has been flagged as async.
Users choosing to allow the call to be completed asynchronously can simply ignore the Future but those wanting to act after registration is complete cannot do so without this change.