add test to ensure narrow bars are displayed similar to v1.52.1 and before

archmoj · archmoj · commit 7f3fb34fc330 · 2020-02-11T10:35:03.000-05:00
diff --git a/test/jasmine/tests/bar_test.js b/test/jasmine/tests/bar_test.js
@@ -2026,75 +2026,24 @@ describe('A bar plot', function() {
         .then(done);
     });
 
-    it('should show up narrow bars as thin bars', function(done) {
-        var mock = Lib.extendDeep({}, require('@mocks/bar_show_narrow.json'));
-
-        function getArea(path) {
-            var pos = path
-                .substr(1, path.length - 2)
-                .replace('V', ',')
-                .replace('H', ',')
-                .replace('V', ',')
-                .split(',');
-            var dx = +pos[0];
-            var dy = +pos[1];
-            dy -= +pos[2];
-            dx -= +pos[3];
-
-            return Math.abs(dx * dy);
-        }
-
-        Plotly.plot(gd, mock)
-        .then(function() {
-            var nodes = gd.querySelectorAll('g.point > path');
-            expect(nodes.length).toBe(16, '# of bars');
-
-            [
-                [0, true],
-                [1, true],
-                [2, true],
-                [3, true],
-                [4, true],
-                [5, true],
-                [6, true],
-                [7, true],
-                [8, true],
-                [9, true],
-                [10, true],
-                [11, true],
-                [12, true],
-                [13, true],
-                [14, true],
-                [15, true]
-            ].forEach(function(e) {
-                var i = e[0];
-                var d = nodes[i].getAttribute('d');
-                var visible = e[1];
-                expect(getArea(d) > 0).toBe(visible, 'item:' + i);
-            });
-        })
-        .catch(failTest)
-        .then(done);
-    });
+    function getArea(path) {
+        var pos = path
+            .substr(1, path.length - 2)
+            .replace('V', ',')
+            .replace('H', ',')
+            .replace('V', ',')
+            .split(',');
+        var dx = +pos[0];
+        var dy = +pos[1];
+        dy -= +pos[2];
+        dx -= +pos[3];
+
+        return Math.abs(dx * dy);
+    }
 
     it('should not show up null and zero bars as thin bars', function(done) {
         var mock = Lib.extendDeep({}, require('@mocks/bar_hide_nulls.json'));
 
-        function getArea(path) {
-            var pos = path
-                .substr(1, path.length - 2)
-                .replace('V', ',')
-                .replace('H', ',')
-                .replace('V', ',')
-                .split(',');
-            var dx = +pos[0];
-            var dy = +pos[1];
-            dy -= +pos[2];
-            dx -= +pos[3];
-
-            return Math.abs(dx * dy);
-        }
-
         Plotly.plot(gd, mock)
         .then(function() {
             var nodes = gd.querySelectorAll('g.point > path');
@@ -2127,6 +2076,39 @@ describe('A bar plot', function() {
         .catch(failTest)
         .then(done);
     });
+
+    describe('show narrow bars', function() {
+        ['initial zoom', 'after zoom out'].forEach(function(zoomStr) {
+            it(zoomStr, function(done) {
+                var mock = Lib.extendDeep({}, require('@mocks/bar_show_narrow.json'));
+
+                if(zoomStr === 'after zoom out') {
+                    mock.layout.xaxis.range = [-14.9, 17.9];
+                    mock.layout.xaxis2.range = [17.9, -14.9];
+                    mock.layout.xaxis3.range = [-3.9, 4.9];
+                    mock.layout.xaxis4.range = [4.9, -3.9];
+
+                    mock.layout.yaxis.range = [-3.9, 4.9];
+                    mock.layout.yaxis2.range = [4.9, -3.9];
+                    mock.layout.yaxis3.range = [-14.9, 17.9];
+                    mock.layout.yaxis4.range = [17.9, -14.9];
+                }
+
+                Plotly.plot(gd, mock)
+                .then(function() {
+                    var nodes = gd.querySelectorAll('g.point > path');
+                    expect(nodes.length).toBe(16, '# of bars');
+
+                    for(var i = 0; i < 16; i++) {
+                        var d = nodes[i].getAttribute('d');
+                        expect(getArea(d) > 0).toBe(true, 'item:' + i);
+                    }
+                })
+                .catch(failTest)
+                .then(done);
+            });
+        });
+    });
 });
 
 describe('bar visibility toggling:', function() {
