Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit d3a174b

Browse files
committed
readme/makeme tweaks
1 parent 3b8c8d9 commit d3a174b

File tree

4 files changed

+26
-14
lines changed

4 files changed

+26
-14
lines changed

Week1/MAKEME.md

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -62,34 +62,34 @@ You can find detailed information about the GitHub API by means of the link list
6262
6363
### 1.3 Coding Style
6464

65-
In the JavaScript3 module, we will be introducing a preferred coding style and supporting tools to help you write _"clean code"_. There are a number of popular JavaScript "style guides" available of which the one developed by Airbnb will be adopted for this homework. It is documented here:
65+
In this homework we will be introducing a preferred coding style and supporting tools to help you write _"clean code"_. A number of popular [_JavaScript Style Guides_](https://codeburst.io/5-javascript-style-guides-including-airbnb-github-google-88cbc6b2b7aa) have recently emerged of which the one developed by [Airbnb](https://github.com/airbnb/javascript) has been chosen for this homework and is recommended for subsequent use during the HYF curriculum. It is documented here:
6666

6767
- [Airbnb JavaScript Style Guide](https://github.com/airbnb/javascript)
6868

69-
While you do not need to read this guide in detail, it is recommended that you review sections 1-8, 12-13, 15-21 and 23. Adherence to many of the recommendations of this guide is enforced in this homework by tools installed during the project preparation step below. You will see error and warning messages in the VSCode editor when your code deviates from the recommended style. An additional check will be done when you submit your homework as a pull request on GitHub.
69+
While you do not need to read this guide in detail, it is recommended that you review sections 1-8, 12-13, 15-21 and 23. The tools installed during the project preparation step below will help you to implement these guidelines in your code. You will see error and warning messages in the VSCode editor when your code deviates from the recommended style. An additional check will be done when you submit your homework as a pull request on GitHub.
7070

7171
### 1.5 Preparation
7272

73-
You will be working on this same application during the next three weeks. For each week you will need to create a new Git branch, as listed in the Table 1 below.
73+
You will be working on the same application during the next three weeks. For each week you will need to create a new Git branch, as listed in the Table 1 below.
7474

75-
| Week | Branch | Assignment |
76-
| :--: | ------- | ------------------------------------------------------------------------------------------------ |
77-
| 1 | `week1` | Create a basic application using callbacks to handle network requests. |
78-
| 2 | `week2` | - Refactor the callbacks to promises.<br>- Make the UI responsive. |
79-
| 3 | `week3` | - Refactor the application to use ES6 Classes and async/await.<br>- Make the app ARIA-compliant. |
75+
| Week | Branch | Assignment |
76+
| :--: | ------- | -------------------------------------------------------------------------------------------------------------------------------- |
77+
| 1 | `week1` | - Create a basic application using callbacks to handle network requests. |
78+
| 2 | `week2` | Based on the `week1` branch:<br>- Refactor the callbacks to promises.<br>- Make the UI responsive. |
79+
| 3 | `week3` | Based on the `week2` branch:<br>- Refactor the application to use ES6 Classes and async/await.<br>- Make the app ARIA-compliant. |
8080

8181
<small>Table 1. Homework schedule</small>
8282

8383
**Instructions**
8484

8585
1. Fork the JavaScript3 repository (_this repository_) to your own GitHub account.
8686
2. Clone the fork to your laptop.
87-
3. Open the `JavaScript3` folder from the cloned repository in VSCode.
87+
3. Open the newly created `JavaScript3` folder from the cloned repository in VSCode.
8888
4. Install the following extension in VSCode:
8989

9090
**Prettier - Code formatter**.
9191

92-
5. Open a Terminal window in VSCode and type the following command to install Prettier and ESLint tools required for the homework:
92+
5. Open a Terminal window in VSCode and type the following command to install Prettier and ESLint tools as required for the homework:
9393

9494
```
9595
npm install
@@ -121,7 +121,9 @@ In week 1, you should only modify `index.js` and `style.css`.
121121

122122
_**Do not modify any other files at this time!**_
123123

124-
> Although you should only modify files in the `homework` folder, we recommend that you always open the `JavaScript3` folder rather tham the `homework` folder in VSCode. The `JavaScript3` folder contains the actual git repository.
124+
Although you should only modify files in the `homework` folder, we recommend that you always open the `JavaScript3` folder rather than directly opening the `homework` folder in VSCode. The `JavaScript3` folder contains the actual git repository and the configuration files required by the installed tools.
125+
126+
_**Do not change or delete any files outside of the `homework` folder!**_
125127

126128
#### 1.5.1 A first examination
127129

@@ -210,7 +212,9 @@ It should include the following components:
210212

211213
### 1.7 Handing in your homework
212214

213-
To determine if your code will be accepted when you submit your homework as a pull request you need to ensure that it does not contain linting errors. Open a terminal window in VSCode and type the following command:
215+
If necessary, review the instructions how to [Hand in homework](https://github.com/HackYourFuture/fundamentals/blob/master/fundamentals/homework_pr.md) using GitHub pull request.
216+
217+
To test whether your code will be accepted when you submit your homework as a pull request you need to ensure that it does not contain ESLinr errors. Open a terminal window in VSCode and type the following command:
214218

215219
```
216220
npm test

Week1/README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,3 +28,7 @@ Here are resources that we like you to read as a preparation for the first lectu
2828
> Note that this article includes some code examples writte in Java, but the same principles can equally be applied to JavaScript.
2929
3030
- [Clean Code concepts adapted for JavaScript](https://github.com/ryanmcdermott/clean-code-javascript)
31+
32+
### Handing in homework using GitHub pull requests
33+
34+
- [Handing in homework](https://github.com/HackYourFuture/fundamentals/blob/master/fundamentals/homework_pr.md)

Week2/MAKEME.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,9 @@ You will continue to work on the files `index.js` and (possibly) `style.css`.
4949

5050
### 3.3 Handing in your homework
5151

52-
To determine if your code will be accepted when you submit your homework as a pull request you need to ensure that it does not contain linting errors. Open a terminal window in VSCode and type the following command:
52+
If necessary, review the instructions how to [Hand in homework](https://github.com/HackYourFuture/fundamentals/blob/master/fundamentals/homework_pr.md) using GitHub pull request.
53+
54+
To test whether your code will be accepted when you submit your homework as a pull request you need to ensure that it does not contain ESLinr errors. Open a terminal window in VSCode and type the following command:
5355

5456
```
5557
npm test

Week3/MAKEME.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,9 @@ For the GitHub application ARIA-compliance means that the Contributors list shou
8080

8181
#### 2.2.4 Handing in your homework
8282

83-
To determine if your code will be accepted when you submit your homework as a pull request you need to ensure that it does not contain linting errors. Open a terminal window in VSCode and type the following command:
83+
If necessary, review the instructions how to [Hand in homework](https://github.com/HackYourFuture/fundamentals/blob/master/fundamentals/homework_pr.md) using GitHub pull request.
84+
85+
To test whether your code will be accepted when you submit your homework as a pull request you need to ensure that it does not contain ESLinr errors. Open a terminal window in VSCode and type the following command:
8486

8587
```
8688
npm test

0 commit comments

Comments
 (0)