Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[intl-displaynames]: there is no support for "calendar" and "dateTimeField" type #3387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jguddas opened this issue Jan 24, 2022 · 1 comment
Open

[intl-displaynames]: there is no support for "calendar" and "dateTimeField" type #3387

jguddas opened this issue Jan 24, 2022 · 1 comment
Labels
bug pinned

Comments

@jguddas
Copy link

jguddas commented Jan 24, 2022

Which package?

intl-displaynames

Describe the bug

formatjs/packages/intl-displaynames/index.ts

Line 21 in f730b91

type: 'language' | 'region' | 'script' | 'currency'

Has no 'calendar' | 'dateTimeField' even though it works (only tested without polyfill).

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DisplayNames/DisplayNames#using_type_datetimefield

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DisplayNames/DisplayNames#using_type_calendar

Expected behavior

Should be

type: 'language' | 'region' | 'script' | 'currency'  | 'calendar' | 'dateTimeField'

Possible issues

The polyfill might need to be adjusted.
@jguddas jguddas added the bug label Jan 24, 2022
@longlho
Copy link
Member

longlho commented Feb 6, 2022

yeah we haven't worked on that yet it's newer in the spec

@longlho longlho added the pinned label Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug pinned
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@longlho @jguddas