-
Notifications
You must be signed in to change notification settings - Fork 303
Closed
Labels
bugSomething isn't working.Something isn't working.
Description
I had some dkim alignment issues with mail domains listed as a TLD in https://publicsuffix.org/list/public_suffix_list.dat
For example: if gitlab.io is used to send DKIM DMARC mails, with a policy adkim=r restricted policy, the isAligned() function will return an error because it cannot find a domain:
https://github.com/foxcpp/maddy/blob/master/internal/dmarc/evaluate.go#L212
It can be fixed by adding in line 209:
tld, _ := publicsuffix.PublicSuffix(fromDomain)
if strings.EqualFold(fromDomain, tld) {
return strings.EqualFold(fromDomain, authDomain)
}
If you want, i can make a PR for that, or if you have another solution feel free! thanks!
I know the DKIM RFC doesnt handle this case well and require to use a Organisational Domain but there are quite a few big goverment domains used for mailing in that list.
Metadata
Metadata
Assignees
Labels
bugSomething isn't working.Something isn't working.