fix(sheet): correctly remove resize handler

nolimits4web · nolimits4web · commit ffb5c8c5ba2c · 2024-02-27T12:40:44.000+03:00
fixes #4251
diff --git a/src/core/components/sheet/sheet-class.js b/src/core/components/sheet/sheet-class.js
@@ -669,7 +669,6 @@ class Sheet extends Modal {
         $(document).on('keydown', onKeyDown);
       }
       $el.prevAll('.popup.modal-in').addClass('popup-behind');
-
       app.on('resize', onResize);
       if (sheet.params.scrollToEl) {
         scrollToElementOnOpen();
@@ -710,8 +709,8 @@ class Sheet extends Modal {
       if (sheet.params.swipeToStep || useBreakpoints) {
         $el.removeClass('modal-in-swipe-step modal-in-breakpoint');
         sheet.emit('local::_swipeStep', false);
-        app.off('resize', onResize);
       }
+      app.off('resize', onResize);
       if (sheet.params.closeOnEscape) {
         $(document).off('keydown', onKeyDown);
       }

Original file line number	Diff line number	Diff line change
`@@ -669,7 +669,6 @@ class Sheet extends Modal {`
`669`	`669`	`$(document).on('keydown', onKeyDown);`
`670`	`670`	`}`
`671`	`671`	`$el.prevAll('.popup.modal-in').addClass('popup-behind');`
`672`		`-`
`673`	`672`	`app.on('resize', onResize);`
`674`	`673`	`if (sheet.params.scrollToEl) {`
`675`	`674`	`scrollToElementOnOpen();`
`@@ -710,8 +709,8 @@ class Sheet extends Modal {`
`710`	`709`	`if (sheet.params.swipeToStep \|\| useBreakpoints) {`
`711`	`710`	`$el.removeClass('modal-in-swipe-step modal-in-breakpoint');`
`712`	`711`	`sheet.emit('local::_swipeStep', false);`
`713`		`- app.off('resize', onResize);`
`714`	`712`	`}`
	`713`	`+ app.off('resize', onResize);`
`715`	`714`	`if (sheet.params.closeOnEscape) {`
`716`	`715`	`$(document).off('keydown', onKeyDown);`
`717`	`716`	`}`