get bg build right

dsyme · dsyme · commit 9656fb9b2646 · 2015-10-16T13:09:26.000+01:00
diff --git a/src/fsharp/vs/IncrementalBuild.fsi b/src/fsharp/vs/IncrementalBuild.fsi
@@ -107,7 +107,7 @@ module internal IncrementalFSharpBuild =
       /// Whether there are any 'live' type providers that may need a refresh when a project is Cleaned
       member ThereAreLiveTypeProviders : bool
 #endif
-      /// Perform one step in the F# build (type-checking only, the type check is not finalized)
+      /// Perform one step in the F# build. Return true if the background work is finished.
       member Step : unit -> bool
 
       /// Get the preceding typecheck state of a slot, without checking if it is up-to-date w.r.t.
diff --git a/src/fsharp/vs/Reactor.fs b/src/fsharp/vs/Reactor.fs
@@ -83,7 +83,7 @@ module internal Reactor =
                                 let span = System.DateTime.Now - time
                                 //if span.TotalMilliseconds > 100.0 then 
                                 Debug.WriteLine("Reactor: <-- background step, remaining {0}, took {1}ms", inbox.CurrentQueueLength, span.TotalMilliseconds)
-                                return! loop ((if res then None else Some bgOp), onComplete)
+                                return! loop ((if res then Some bgOp else None), onComplete)
                             | None, None -> failwith "unreachable, should have used inbox.Receive"
                       }
             async { 

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ module internal Reactor =`
`83`	`83`	`let span = System.DateTime.Now - time`
`84`	`84`	`//if span.TotalMilliseconds > 100.0 then`
`85`	`85`	`Debug.WriteLine("Reactor: <-- background step, remaining {0}, took {1}ms", inbox.CurrentQueueLength, span.TotalMilliseconds)`
`86`		`- return! loop ((if res then None else Some bgOp), onComplete)`
	`86`	`+ return! loop ((if res then Some bgOp else None), onComplete)`
`87`	`87`	`\| None, None -> failwith "unreachable, should have used inbox.Receive"`
`88`	`88`	`}`
`89`	`89`	`async {`