May I get to know if this is going to be addressed? If it is not, it's fine. Then I will work around this issue somehow. But I need to know.

P.S. I do not want to present this kind of logo to my app users. Because the app "does not look quite right" from its very start. The app is fsx.exe of the FSharpFar package. It is effectively fsi.exe with some extensions related to FSharpFar.

Is it possible for you to send a pull request for this issue?

Hi @dsyme , yes, if I am able to figure out how to fix this. Any hints before I start hacking? @baronfel ?

To start with, I am not sure which repository to use for the PR, this or upstream.

Yes, it should go to dotnet/fsharp

Yes, it should go to dotnet/fsharp

But it does not have this problem. Its both dotnet fsi and fsi.exe are in order.

My understanding is it's FCS build issue, not F# code issue. Namely I see that .targets files use variables $(FSPRODUCTVERSION) and $(FSLANGUAGEVERSION) which are then used for FSharpBannerVersion in CompilerLocationUtils.fs. Apparently these variables are not set on building FCS.

NB And if this is the case, I am not very optimistic about me tweaking the build.

But it does not have this problem. Its both dotnet fsi and fsi.exe are in order.

I am guessing the FSI.EXE built using FsiExe sample source against the FSHarp.Compiler.Service built in that repo will have the issue

My understanding is it's FCS build issue, not F# code issue. Namely I see that .targets files use variables $(FSPRODUCTVERSION) and $(FSLANGUAGEVERSION) which are then used for FSharpBannerVersion in CompilerLocationUtils.fs. Apparently these variables are not set on building FCS.

Yes, I believe that will be the issue

In the upstream and this repo, I cannot find where these variables are set.
Wild guess, are they supposed to exist as pre-set environment variables?

Those values are MSBuild properties set in eng/Versions.props, and they are used in the fcs/Directory.Build.targets to generate a source file that contains a module like

module internal FSharp.BuildProperties

let fsProductVersion = "<value of msbuild property FSPRODUCTVERSION>"
let fsLanguageVersion = "<value of msbuild property FSLANGUAGEVERSION>

With that module in place, the values for the banner version can be set in CompilerLocationUtils.fs, as FSharpEnvironment.FSharpBannerVersion. This value is set conditionally based on build defines of LOCALIZATION_FSBUILD, LOCALIZATION_FSCOMP, or none, so my guess is that the proper define isn't being set in the sample fsi project file.

Hi @baronfel

so my guess is that the proper define isn't being set in the sample fsi project file

It is not about the fsi sample (which just uses FCS, just like my app).

My app uses FCS NuGet package which was already built with these missing variables. It's too late to set anything on building on my side.

Hey, thanks for the clarification. I got sidetracked on the initial reproduction steps being the fsi sample. Along those lines, I think it might be as simple as explicitly including the Import of ./eng/Versions.props in the Project file for the FSharp.Compiler.Service project. We had to do similar things for the FSharp.Compiler.Service.Tests.fsproj for dependency version reasons, if I recall.

Yes, adding the line <Import Project="..\..\eng\Versions.props"/> does the trick (the sample FsiExe happily shows versions in the logo, and other apps will, I presume):

FSharp.Compiler.Service.fsproj

<Project Sdk="Microsoft.NET.Sdk">
  <Import Project="..\netfx.props" />
  <Import Project="..\..\src\buildtools\buildtools.targets" />
  <Import Project="..\..\eng\Versions.props"/>

Is this change OK?
How do we proceed?

You should submit that change upstream to dotnet/fsharp, and it'll get merged there. Once it does I'll port the change here and release a new point release of the FCS nuget, which you can update to. It will be a good chance to test out the new publish/deploy workflows I just implemented :)

@baronfel
It's done, please review, as required: dotnet/fsharp#9419

I can see it fixed in the just released 36.0.2.
Closing, thank you all!

Thank you for testing so quickly!