Fix Reverse Geocode failure - Here maps - Undefined index: LocationId (#1190)

FloppyChips · smackintosh · web-flow · commit 560f5cf1ab91 · 2023-07-09T15:29:16.000+02:00
Here Issue 1189
Undefined index: LocationId at /var/www/api/html/releases/20230704155244/vendor/geocoder-php/here-provider/Here.php:258
Not all the location responses from Here maps reverse geocode API include LocationId, e.g. if the LocationType is area.

Co-authored-by: smackintosh &lt;stuart.mackintosh@track-metrics.com&gt;
diff --git a/src/Provider/Here/Here.php b/src/Provider/Here/Here.php
@@ -255,7 +255,7 @@ private function executeQuery(string $url, int $limit): Collection
 
             /** @var HereAddress $address */
             $address = $builder->build(HereAddress::class);
-            $address = $address->withLocationId($location['LocationId']);
+            $address = $address->withLocationId($location['LocationId'] ?? null);
             $address = $address->withLocationType($location['LocationType']);
             $address = $address->withAdditionalData(array_merge($additionalData, $extraAdditionalData));
             $address = $address->withShape($location['Shape'] ?? null);
