Replace empty() by more strict checks (#1125)

jbelien · web-flow · commit db813792bf10 · 2021-06-21T08:13:22.000+02:00
* Replace empty() by stricter checks

* Apply StyleCI fixes

* Compare with empty string instead of checking length

* Compare with empty array instead of checking count

* Compare with empty string instead of checking length
diff --git a/Provider/AbstractHttpProvider.php b/Provider/AbstractHttpProvider.php
@@ -96,7 +96,7 @@ protected function getParsedResponse(RequestInterface $request): string
         }
 
         $body = (string) $response->getBody();
-        if (empty($body)) {
+        if ('' === $body) {
             throw InvalidServerResponse::emptyResponse((string) $request->getUri());
         }
 

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ protected function getParsedResponse(RequestInterface $request): string`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`$body = (string) $response->getBody();`
`99`		`- if (empty($body)) {`
	`99`	`+ if ('' === $body) {`
`100`	`100`	`throw InvalidServerResponse::emptyResponse((string) $request->getUri());`
`101`	`101`	`}`
`102`	`102`