-
Notifications
You must be signed in to change notification settings - Fork 134
Extend rfl::AllowRawPtrs to std::string_view #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @lixin-wei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces support for deserializing std::string_view
types, a feature previously unsupported due to memory safety concerns. The change allows std::string_view
deserialization only when the rfl::AllowRawPtrs
processor is explicitly used, signaling that the user is aware of and prepared to manage the lifetime of the underlying string data. This provides greater flexibility for advanced use cases while maintaining safety for default configurations.
Highlights
- Enable
std::string_view
Deserialization: I've enabled the deserialization ofstd::string_view
types within thereflect-cpp
library. Previously, this was explicitly disallowed due to the inherent dangers ofstd::string_view
not owning its underlying data. - Conditional Behavior with
rfl::AllowRawPtrs
: Thestd::string_view
deserialization is now permitted only when therfl::AllowRawPtrs
processor is active. Ifrfl::AllowRawPtrs
is not used, the system will continue to preventstd::string_view
deserialization with astatic_assert
and an error, guiding users tostd::string
or theAllowRawPtrs
processor. - Memory Management for
std::string_view
: Whenrfl::AllowRawPtrs
is enabled, the deserialized string data is now dynamically allocated usingnew char[]
and copied from an intermediatestd::string
. The resultingstd::string_view
points to this newly allocated memory. Users are responsible for managing the lifetime of this dynamically allocated memory. - New Test Case: A new test case has been added in
tests/json/test_pointer_fields.cpp
to validate the correct serialization and deserialization ofstd::string_view
whenrfl::AllowRawPtrs
is applied.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The code changes introduce the ability to deserialize std::string_view
. However, the current implementation introduces a critical memory leak due to missing memory management for the allocated string data. The review highlights this issue in both the parser logic and the test case.
d2855dd
to
c5a86a0
Compare
Support deserializing std::string_view as discussed in #454 (comment)