Fix bug reading with 'tagged' variants when a variant is non-copyable #464
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @jmcken8, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves a critical bug that prevented the correct reading of 'tagged' variants when one of the variant's alternative types was non-copyable. The fix involves a subtle but important change in the internal parsing mechanism to allow for proper movement of such types, complemented by a new, robust test case that specifically validates this scenario.
Highlights
- Bug Fix: Non-copyable Variant Parsing: Corrected the parsing logic within
rfl::parsing::Parser_rfl_variant.hppto properly handlerfl::Varianttypes that contain non-copyable members. This was achieved by changing a lambda parameter fromconst auto&toauto&, enablingstd::moveto correctly transfer ownership of non-copyable elements during deserialization. - New Test Case for Non-copyable Types: Introduced a new test scenario in
test_add_tag_to_rfl_variant.cppby modifying thebutton_released_tstruct to include anrfl::Box<int>member, which is a non-copyable type. This ensures that the fix addresses the specific issue of reading variants with non-copyable elements. - Test Initialization Adaptation: Updated the test case in
test_add_tag_to_rfl_variant.cppto usestd::vector::emplace_backfor populating the test data. This change was necessary because thebutton_released_tstruct now contains a non-copyable member, andemplace_backallows for in-place construction without requiring copy or move constructors for the elements themselves.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Added a test. Needed to change the test to emplace each element rather than initializer_list due to the non-copyable element.
6d778de to
7e52252
Compare
|
@jmcken8 , makes sense. Thank you for the contribution! |
Added a test. Needed to change the test to emplace each element rather than initializer_list due to the non-copyable element.