-
-
Notifications
You must be signed in to change notification settings - Fork 451
Add Sentry Log feature to Java SDK #4372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Instructions and example for changelogPlease add an entry to Example:
If none of the above apply, you can opt out of this check by adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, otherwise LGTM as a first implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doing a drive by review since we also implement logs for Dart :)
public final class SentryLogEvent implements JsonUnknown, JsonSerializable { | ||
|
||
private @NotNull SentryId traceId; | ||
private @NotNull Double timestamp; | ||
|
||
private @NotNull String body; | ||
|
||
private @Nullable SentryLevel level; | ||
private @Nullable Map<String, SentryLogEventAttributeValue> attributes; | ||
private @Nullable Map<String, Object> unknown; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the optional severity_number
is missing which later on is inferred by the SDK if not set, e.g
📜 Description
Add API for capturing logs.
💡 Motivation and Context
Partial implementation for #4350
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps