You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I searched using keywords relevant to my issue to make sure that I am creating a new issue that is not already open (or closed).
I reviewed the Discussions, and have a new and useful enhancement to share.
Feature Description
Currently various GGML backends have their own logging routines. These need to be unified and updated to behave similar to those defined in llama-impl.h/llama.h.
Motivation
Cleans up redundant logging behavior.
Possible Implementation
This change will minimally require:
Updating ggml-impl.h with a series of GGML_LOG_* macros for the various log levels.
Adding a ggml_log_set routine to ggml.h.
Adding internal/default logging callbacks in ggml.cpp/ggml-impl.h.
Modifying the llama_log_set routine to internally call ggml_log_set so they use the same logging mechanism.
Remove backend-specific log-setup logic (e.g. ggml_backend_metal_log_set_callback &co.), as registered in the current llama_log_set routine.
For each backend, replace back-end specific log invocations (e.g. VK_LOG_DEBUG) with the new unified macros.
The text was updated successfully, but these errors were encountered:
Prerequisites
Feature Description
Currently various GGML backends have their own logging routines. These need to be unified and updated to behave similar to those defined in llama-impl.h/llama.h.
Motivation
Cleans up redundant logging behavior.
Possible Implementation
This change will minimally require:
ggml-impl.h
with a series ofGGML_LOG_*
macros for the various log levels.ggml_log_set
routine toggml.h
.llama_log_set
routine to internally callggml_log_set
so they use the same logging mechanism.ggml_backend_metal_log_set_callback
&co.), as registered in the currentllama_log_set
routine.VK_LOG_DEBUG
) with the new unified macros.The text was updated successfully, but these errors were encountered: