Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 5eead73

Browse files
committed
winmake.py: print err in case of permission error
1 parent 8d47277 commit 5eead73

3 files changed

Lines changed: 12 additions & 11 deletions

File tree

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ clean: ## Remove all build files.
4747
dist/ \
4848
docs/_build/ \
4949
htmlcov/ \
50+
pytest-cache-files* \
5051
wheelhouse
5152

5253
.PHONY: build

scripts/internal/winmake.py

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
import argparse
1616
import atexit
1717
import ctypes
18-
import errno
1918
import fnmatch
2019
import os
2120
import shutil
@@ -124,16 +123,21 @@ def rm(pattern, directory=False):
124123
def safe_remove(path):
125124
try:
126125
os.remove(path)
127-
except OSError as err:
128-
if err.errno != errno.ENOENT:
129-
raise
126+
except FileNotFoundError:
127+
pass
128+
except PermissionError as err:
129+
print(err)
130130
else:
131131
safe_print(f"rm {path}")
132132

133133

134134
def safe_rmtree(path):
135+
def onerror(func, path, err):
136+
if not issubclass(err[0], FileNotFoundError):
137+
print(err[1])
138+
135139
existed = os.path.isdir(path)
136-
shutil.rmtree(path, ignore_errors=True)
140+
shutil.rmtree(path, onerror=onerror)
137141
if existed and not os.path.isdir(path):
138142
safe_print(f"rmdir -f {path}")
139143

@@ -282,6 +286,7 @@ def clean():
282286
"*__pycache__",
283287
".coverage",
284288
".failed-tests.txt",
289+
"pytest-cache-files*",
285290
)
286291
safe_rmtree("build")
287292
safe_rmtree(".coverage")
@@ -318,11 +323,7 @@ def test(args=None):
318323
def test_by_name(arg):
319324
"""Run specific test by name."""
320325
build()
321-
sh([
322-
PYTHON,
323-
"-m",
324-
"pytest",
325-
])
326+
sh([PYTHON, "-m", "pytest", arg])
326327

327328

328329
def test_by_regex(arg):

setup.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,6 @@
114114
"vulture",
115115
"wheel",
116116
"pyreadline ; os_name == 'nt'",
117-
"pdbpp ; os_name == 'nt'",
118117
]
119118

120119
macros = []

0 commit comments

Comments
 (0)