Simplify link checker

QuLogic · QuLogic · commit a5c2769f61ea · 2024-02-15T16:04:09.000-05:00
... and debug a bit.
diff --git a/Makefile b/Makefile
@@ -50,8 +50,8 @@ check:
 	./check-num-pages.sh handout-tips.pdf 1
 	./check-num-pages.sh handout-beginner.pdf 1
 	./check-num-pages.sh handout-intermediate.pdf 1
-	./check-links.py cheatsheets.pdf
 	./check-diffs.py
+	./check-links.py cheatsheets.pdf
 
 .PHONY: docs
 docs:
diff --git a/check-links.py b/check-links.py
@@ -8,12 +8,12 @@
 
 refs = [ref for ref in pdf.get_references() if ref.reftype == 'url']
 
-status_codes = list(map(lambda ref: pdfx.downloader.get_status_code(ref.ref), refs))
+status_codes = [pdfx.downloader.get_status_code(ref.ref) for ref in refs]
 
-broken_links = [refs[idx].ref for idx in range(len(refs)) if status_codes[idx] != 200]
+broken_links = [(ref.ref, code) for ref, code in zip(refs, status_codes) if code != 200]
 
 # it seems that Twitter does not respond well to the link checker and throws a 400
-if all(['twitter.com' in url for url in broken_links]):
+if all(['twitter.com' in url for url, _ in broken_links]):
     sys.exit(0)
 else:
     print('Broken links:', broken_links)
